ddunkin / cometclient Goto Github PK

On a iOS5 simulator, the DDCometClient fails to send messages.
The issue is because of uninitialized local variable on the source "DDCometLongPollingTransport.m".
In the method main, there is a local variable "isPolling" which is expected to be initialized as YES, but is not initialized any value.
In out environments, the variable "isPolling" is initialized as YES on iOS4 simulator, but is initialized as NO on iOS5 simulator.
According to the specification of Objective-C, a value of an uninitialized local variable is not undefined.
We should to set initial value explicitly.
In this code, the "isPolling" should be initialized as YES.

We have checked it to be correct.

sometimes occurs a crash in the procedure requestWithMessages of DDCometLongPollingTransport class, when trying to convert the timeout in floatvalue, the message is [CFNumber floatValue]: message sent to deallocated instance.

thks.