Coder Social home page Coder Social logo

konsensus-app-frontend's People

Contributors

dependabot[bot] avatar safaal28 avatar stella-cai avatar windosaurus avatar

Forkers

safaal28

konsensus-app-frontend's Issues

Preview file as a modal

When clicking a file on a page such as recents, be able to preview the file before opening the entirety of it.

Some workflows have no defined timeouts

This repo has workflows that have no defined timeouts.

GitHub Actions gives the DCSIL organization up to 3000 minutes per month. To ensure a single build doesn't spend hours eating up those minutes, we limit each job to 20 minutes.
Please add a timeout to your jobs. We will disable your actions until you add them.

Docs: https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes
Example:

jobs:
  build:
    runs-on: ubuntu-latest
    timeout-minutes: 20 # Add this line here

Affected Workflows:

Workflow Path Job Re-enable
.github/workflows/node.js.yml build https://github.com/dcsil/konsensus-app-frontend/actions/workflows/node.js.yml

Lock File

A feature for all files is the ability to lock them

  • decide what locking entails -> will it still be available to be shared? does it only mean it cannot be further edited?

Disabling GitHub Actions

Congratulations on finishing the course!

To make sure we have have workers for the next term, we have automatically disabled your repository's actions.

Feel free to make this repo public or fork to your own org, but we do ask that you leave a copy in the DCSIL org :)

Implement functional page numbers

image

Currently the buttons don't work and load regardless of how many file rows there are.

  • determine how many files should load on a single page
  • load page numbers dynamically, so that if there is no other page then no page numbers are loaded, and if there is only 1 other page then only that number will show up

Add repo to Code Climate

Code Climate Quality Checks are required for the final software we submit.

Software Requirements: All of your repos have been added to Code Climate. Your repo should maintain a minimum "B" average in "maintainability".

This isn't the best metric to ensure code quality, and in practice, you would use this to help inform a decision, not make a decision. In this case, checking a grade is a simple way for the teaching staff to gauge code quality without spending hours reviewing each repository.

Some workflows have no defined timeouts

This repo has workflows that have no defined timeouts.

GitHub Actions gives the DCSIL organization up to 3000 minutes per month. To ensure a single build doesn't spend hours eating up those minutes, we limit each job to 20 minutes.
Please add a timeout to your jobs. We will disable your actions until you add them.

Docs: https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes
Example:

jobs:
  build:
    runs-on: ubuntu-latest
    timeout-minutes: 20 # Add this line here

Affected Workflows:

Workflow Path Job Re-enable
.github/workflows/main.yml deploy https://github.com/dcsil/konsensus-app-frontend/actions/workflows/main.yml

Some workflows have no defined timeouts or are not using self-hosted

This repo has workflows that have no defined timeouts and/or are not using self-hosted.

We use self hosted runners to avoid overage costs associated with GitHub Actions. However, we don't have a lot of workers to handle all of the load.
To ensure a single build doesn't spend hours and monopolize our workers, we limit each job to 20 minutes.
Please add a timeout to your jobs. We will disable your actions until you add them.

Your build may also be missing self-hosted in the runs-on field.

Docs: https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes
Example:

jobs:
  build:
    runs-on: self-hosted # This is required
    timeout-minutes: 20 # Add this line here

Affected Workflows:

Workflow Path Job Re-enable
.github/workflows/main.yml client_tests https://github.com/dcsil/konsensus-app-frontend/actions/workflows/main.yml

Organization Invite

Admin user should be able invite new users to the app and to their organization via email through their profile page. A component needs to be built for the profile page that shows the list of people in their organization already with a button somewhere that gives them the prompt to add new org members via email.

Improve test coverage

Test coverage needs to be at least 65%

image

Thresholds:
60-65% = 10pts
55-59.999% = 8pts
50-54.999% = 5pts
< 50% = 0
If your application is not uploading test coverage to Code Climate and the DCSIL App, it will be considered to have a coverage of 0%

Organization Page

User should be able to see who is in their organization on a page that can be accessed from here:
Screen Shot 2022-03-15 at 12 37 56 PM

The page needs to be created or could also just be linked to the profile page. TBD

Ensure We Meet Accessibility Requirements

This is the checklist: https://github.com/dcsil/CSC491/blob/main/assignments/accessibility_checklist.md

If your app is not easily accessible, then you will receive a 0% for the evaluation of the running software

Design and Accessibility

Default Styles: The design doesn't need to be state of the art, super modern, and feel like it's been designed by a star designers but it does need to look decent.
Use a consistent colour scheme (recommend looking at a site like https://paletton.com/, docs on this in the DCSIL app).
Use a framework/template like one of these, or design something that is coherent.
If you use something like Material UI or Bootstrap, you're using components consistently and aren't relying on the default colours
We want to give our users a nice experience, not confuse them. For example:
if you use a certain colour for indicating some state... use it consistently
if you use a component for navigation, use it consistently, don't suddenly change what the user can expect on a page
if you have a standard layout, stick to it
Don't suddenly shift a user's expectations without really good reasons
DO NOT use only colour to represent items in graphs. Use overlays, icons, and more. Colour is not accessible to people with colourblindness, low contrast, etc. (do not use just red and green, for example, use icons too)

Some workflows have no defined timeouts

This repo has workflows that have no defined timeouts.

GitHub Actions gives the DCSIL organization up to 3000 minutes per month. To ensure a single build doesn't spend hours eating up those minutes, we limit each job to 20 minutes.
Please add a timeout to your jobs. We will disable your actions until you add them.

Docs: https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes
Example:

jobs:
  build:
    runs-on: ubuntu-latest
    timeout-minutes: 20 # Add this line here

Affected Workflows:

Workflow Path Job Re-enable
.github/workflows/node.js.yml build https://github.com/dcsil/konsensus-app-frontend/actions/workflows/node.js.yml

Can't star from suggested

Currently, I can only star on the All Files view on the "All Files" section, but I cannot star the same files on Suggested.

Choose Stylesheet

For design consistency, we need to decide:

  • the typography style
  • buttons (solid, outline, hover, etc.)
  • input fields

Create functional actions

When clicking the three buttons on the right of a file row, we can see three actions:
image

  • Add the decided actions from the prototype
  • Implement them

Auth Page

We need to create a straightforward sign-up and sign-in page that mirrors the rest of our figma designs and can link with our backend.

File components

The file component should be:

  • Different for each file type
  • Appear differently depending on which page
  • Be movable from folder to folder

The folder component should be:

  • Appear different depending on the number of files in it

Collaborator Flow

User should be able to add collaborators to a single file.

Adding:
The file component should have a dropdown for this that pulls up a list of people inside their organization that they can give access to.

Removing:
The file component should have a dropdown that pulls a list of the people with access already and gives the user a button to remove them.

Some workflows have no defined timeouts or are not using self-hosted

This repo has workflows that have no defined timeouts and/or are not using self-hosted.

We use self hosted runners to avoid overage costs associated with GitHub Actions. However, we don't have a lot of workers to handle all of the load.
To ensure a single build doesn't spend hours and monopolize our workers, we limit each job to 20 minutes.
Please add a timeout to your jobs. We will disable your actions until you add them.

Your build may also be missing self-hosted in the runs-on field.

Docs: https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes
Example:

jobs:
  build:
    runs-on: self-hosted # This is required
    timeout-minutes: 20 # Add this line here

Affected Workflows:

Workflow Path Job Re-enable
.github/workflows/upload_coverage.yml coverage https://github.com/dcsil/konsensus-app-frontend/actions/workflows/upload_coverage.yml

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.