dcm4che / dcm4che Goto Github PK

The dcm4che-conf-core-api-3.3.8.jar in Maven contains classes for the Apache Commons BeanUtils and Logging library. This can cause problems if an application is using different versions of these libraries.

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-298

Attributes.addAll() should preserve non-conflicting Private Creator ID tag positions.

This behavior was originally implemented in commit 7c1d8f4

Unfortunately it was broken with the bug fix for http://dcm4che.org/jira/browse/LIB-362 (Commit 764d9c4 ).

The behavior has to be restored (of course also preserving the bug fix for LIB-362).

New unit tests (AttributesTest) should be implemented to ensure that this behavior doesn't break again.

Mac

Windows

Tried this with various other syntaxes and got the same result. I'm looking for j2ki in particular. The input file is a multiframe mammo. Have also tried it with a single frame dicom file.

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-455

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-338

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-415

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-424

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-400

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-380

On the master ( and on the other branches ), on line 1228 of Association.java in createFileMetatInformation ( project dcm4che-net ) we can find :
fmi.setString(Tag.SourceApplicationEntityTitle, VR.SH, getRemoteAET());

The VR use shall be AE and not SH see the following link
https://www.dabsoft.ch/dicom/6/7/#(0002,0016)

This shall be changed to
fmi.setString(Tag.SourceApplicationEntityTitle, VR.AE, getRemoteAET());

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-402

only effected dcm4chee-arc-light branch

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-458

Enable automatic continuous builds and tests using travis-ci.org

Builds will be available on: https://travis-ci.org/dcm4che/dcm4che

when trying to dump:

IOException during read of (7FE0,0010) #524288 @ 1254 java.io.EOFException at org.dcm4che3.util.StreamUtils.readFully(StreamUtils.java:63) at org.dcm4che3.io.DicomInputStream.readFully(DicomInputStream.java:384) at org.dcm4che3.io.DicomInputStream.readValue(DicomInputStream.java:730) at org.dcm4che3.tool.dcmdump.DcmDump.readValue(DcmDump.java:122) at org.dcm4che3.io.DicomInputStream.readAttributes(DicomInputStream.java:516) at org.dcm4che3.io.DicomInputStream.readDataset(DicomInputStream.java:444) at org.dcm4che3.tool.dcmdump.DcmDump.parse(DcmDump.java:87) at org.dcm4che3.tool.dcmdump.DcmDump.main(DcmDump.java:245)

00010ccd.dcm.zip

findscu: Unable to recover non-ASCII text from DICOM attributes

Our PACS stores information in several fields encoded as ISO-8859-1 (latin-1). So far, we were able to recover properly this information using dcmqr (from dcm4che2 toolset) but right now we are unable to recover these fields using findscu (from dcm4che3 toolset).

You can find the description of our problem in the last two messages of this (rather old) thread:
http://forums.dcm4che.org/jiveforums/thread.jspa?messageID=18779
Notice that we were able to solve the problem back in 2011 using dcmqr, but we pretend to use the new findscu software in a new project.

Our storage server does not store information about specific character set (the attribute (0008,0005) is empty), so, maybe our PACS server is not perfectly configured. Would it be possible to recover the proper strings using findscu?

Examples:

dcmqr:

$ LANG=es_ES.iso-8859-1 /usr/local/dcm4che/dcm4che2/bin/dcmqr [email protected]:104 -q 00100020='80701'|iconv -f ISO-8859-1 -t UTF8 | grep '(0008,1030)'

(0008,1030) LO #6 [tórax] Study Description
(0008,1030) LO #6 [tórax] Study Description

Perfect!!!

findscu:

$ LANG=es_ES.iso-8859-1 /usr/local/dcm4che/dcm4che3/bin/findscu -b DCMQR -c [email protected]:104 -m 00100020='80701' -m 00080005='ISO-8859-1' | grep '(0008,1030)'

(0008,1030) LO [t�rax] StudyDescription
(0008,1030) LO [t�rax] StudyDescription

I have tried with different locales, as well as using different values for the SpecificCharacterSet attribute, but so far we have been unable to recover correctly any fields containing non-ASCII characters.

Review changes from @gunterze on the dcm4chee-arc-light branch of the dcm4che repo and merge them back to the master branch.

(This issue was originally opened in Jira and migrated from there: http://dcm4che.org/jira/browse/LIB-389 )

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-419

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-452

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-413

Platform: macOS Sierra 10.12.3
dcm4che version: 3.3.8

To reproduce: convert file with TS explicit VR little endian to deflated using dcm2dcm -t 1.2.840.10008.1.2.1.99 file.dcm file_defl.dcm. Create jpeg file using dcm2jpg file_defl.dcm file.jpg

Result:

Failed to convert file_defl.dcm: null
java.io.EOFException
	at javax.imageio.stream.ImageInputStreamImpl.readFully(ImageInputStreamImpl.java:353)
	at javax.imageio.stream.ImageInputStreamImpl.readFully(ImageInputStreamImpl.java:373)
	at org.dcm4che3.imageio.plugins.dcm.DicomImageReader.readRaster(DicomImageReader.java:295)
	at org.dcm4che3.imageio.plugins.dcm.DicomImageReader.read(DicomImageReader.java:342)
	at org.dcm4che3.tool.dcm2jpg.Dcm2Jpg.readImage(Dcm2Jpg.java:381)
	at org.dcm4che3.tool.dcm2jpg.Dcm2Jpg.convert(Dcm2Jpg.java:360)
	at org.dcm4che3.tool.dcm2jpg.Dcm2Jpg.mconvert(Dcm2Jpg.java:345)
	at org.dcm4che3.tool.dcm2jpg.Dcm2Jpg.main(Dcm2Jpg.java:314)

Does dcm4che's DicomImageReader not support deflated datasets?

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-453

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-252

Introduced by http://www.dcm4che.org/jira/browse/LIB-467

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-357

What Interfaces or Methods I need to implement wado service to handle weasis requests in my Spring boot application?

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-423

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-407

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-285

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-159

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-463

When using the same association for two C-MOVE operations, an idle timeout may expire before the (second) C-MOVE operation is finished.

We are using a Connection in SYNCHRONOUS_MODE, i.e. with maxOpsInvoked = 1, and try to trigger two consecutive C-MOVE operations by calling Association.cmove(String, String, int, Attributes, String, String, DimseRSPHandler). The second call blocks in Association.addDimseRSPHandler(DimseRSPHandler) until the first C-MOVE operation is finished.
As soon as the first C-MOVE operation is finished, a notification is sent out in Association.onDimseRSP(Dimse, Attributes, Attributes). This starts the second C-MOVE operation. After that, an idle timeout is scheduled (in the same method). However, the stopTimeout() method (for stopping the idle timeout) has already been called before the second call to the cmove(...) method has blocked. Therefore, if the second C-MOVE operation takes longer than the idle timeout, the association is wrongly aborted.

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-398

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-329

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-385

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-417

The class SafeClose used throughout the library (and the archive) is a bad idea.
It just silently swallows IOExceptions that happen on close of streams/sockets.
But close usually also involves flushing the stream, and if exceptions are ignored for that it could mean that an incomplete object is written to the stream.

It is a better idea to replace all usages of SafeClose with Java 7 try-with-resources statements. (This would require depending on Java 7 for the library. Currently it is still compatible with Java 6.)
Update: The master branch is now on Java 7, so try-with-resources can be used.

(This issue was originally opened in Jira and migrated from there: http://dcm4che.org/jira/browse/LIB-399 )

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-349

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-440

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-437

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-369

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-441

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-462

How can I export dicom files from my client machine to the pacs server, and how to download dicom files from pacs server to local machine ??

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-409

This issue was migrated from Jira.

Please check the original Jira issue for additional information and the actual Reporter:
http://dcm4che.org/jira/browse/LIB-414

I was starting up with dcm4che again after a few years and was trying to create some Javadoc files. When I tried running man javadoc:javadoc on the modules, I received a long list of errors. I was using Javadoc 8 and many of the problems were due to the information in the javadoc comment related to the schema for the files in the generated-sources sections not having the greater than sign changed to >. I know that Javadoc 8 has a problem with this because it is much stricter on html syntax in the comments. You are using group:javax.xml.bind artifact:jaxb-api version:2.1. According tohttps://jaxb.java.net/2.2.5/docs/release-documentation.html, there was fix between 2.2.3u2 and 2.2.4 that may refer to this.

There are some other Javadoc problems but they appear to be related to the source code.

This is what I received when I ran man javadoc:javadoc
problems.txt

I changed the versions for the following dependencies in dcm4che-audit/pom.xml and that seemed to have removed the problems with the illegal HTML in the Javadoc comments.

The resulting Javadocs can be found at https://bradleyross.github.io/dcm4che/apidocs