dcaslin / d2-checklist

Source for www.d2checklist.com, written in Angular and using the Bungie API

README

What is this repository for?

• This is the front end for www.d2checklist.com, it's written in Angular and Angular Material.

How do I get set up?

Register a new app with Bungie

In order to run the server, you will need to create an application using the Bungie Application Portal. When creating the application, do the following:

• Application Name can be whatever you want
• Website can be left blank
• Application Status can be Private
• OAuth Client type should be Confidential
• Redirect URL should be https://localhost:4200/auth (for running in Development mode).
• Check all the boxes for scope except "Administrate groups and clans..." (that's not needed, checking it won't hurt though)

Setup the Angular app

• Install node and npm and the Angular CLI (cli.angular.io)

• Clone this repository

• Setup a keys.ts file to match keys.example.ts (Visit https://www.bungie.net/en/Application and setup a )

• npm install

• run ./serve.bat (Windows) or ./serve.sh (Mac or *nix)

• Visit https://localhost:4200 (ignore the cert error)

Contribution guidelines

• If you want to contribute, let me know (or submit a pull request)
• This application uses FontAwesome Pro's private repo, so running your own development environment requires stubbing those out. This can be a pain.

Notes

As of 07/24/2020:

• Local development can be done on https://localhost:4200 using included pre-gen certs (no web server or hacked domain required)
• Production build and deployments are done via GitHub Actions triggered on pushes to master
• NPM (not Yarn) is the expected package manager
• We're upgraded to Angular 9.1

d2-checklist's Issues

Blues show up as missing from collections

Weapon vs armor shard and upgrade modes

Reorganize gear mgr buttons, add under "More Options" ellipsis

Too many buttons at the root of the gear manager. Create a new vertical ellipsis button near the "Refresh" Button. Move the following under it.

• "Show" (to control the number of rows shown)
• Sync Locks
• Shard Mode
• Cheap Upgrade Mode
• Show Armor Perks
• Copy Visible (from #4)
• Settings (remaining info from "Utilities" button after moving Shard/Cheap/Sync locks modes)

Investigate allowing clan leaders to kick players

There apparently exists a Bungie API call to kick clan members (https://bungie-net.github.io/multi/operation_post_GroupV2-KickMember.html#operation_post_GroupV2-KickMember). Investigate letting clan leaders use this feature on the clan page.

Show hidden and zero point triumphs in "Search" and "Tracked"

Currently zero point and invisible triumphs are default hidden, even on pages with wildcard searching or that are tracked. This makes the Service Revolvers "Completions" triumph (which is Season 6 and zero pts) much too hard to find.

Search and Tracked should ignore the "hide" flags.

Report non gun kills in PGCR's

Right now only gun kills show, super/melee/grenade do not

Expand target armor perks to handle things like "Light Reactor"

This would require a mapping file of perks. (Perhaps a regex of Perk names that maps to weapon types, rather than the loose matching by name match we have now)

Bow->Combat Bow

!Linear+Fusion Rifle-> Fusion Rifle
Light Reactor-> Fusion Rifle

etc

[No, I don't have regex memorized, that's what Google is for]

We could also add melee, grenade, super, and ability filters perhaps if this were done.

Timb0uton ideas

To sort out later:

• Season specific triumph tab or filter (just the current season) so that in just a couple clicks you could find every triumphs you're missing for the current season.

• on the friends and clan pages, display the triumph score for everyone.

• A more in depth idea for that would be a "featured" triumph tab display all the triumphs that are obtainable currently but limited in time (ex : NF specific, IB, event, season, daily, etc...), but that'd need quite some work...

Support multiple gist URL's for wishlist

URL's will be pipe delimited.

See: https://old.reddit.com/r/destinychecklistnet/comments/bbohyl/are_more_than_two_wishlists_possible/

Spider hangs as "loading" in milestones

Enhance "Recent Teammates" screen

Currently Recent Teammates UI is a copy of the "match search" UI, where searches are done per character, not per account. This feature makes more sense as an account wide search. Users also use this to see if their clan members are participating with each other. So:

• Remove the character toggles and instead make all searches per account (effectively searches up to 3 times, one per char, when a search is done)

• Add a visual report somewhere that shows

1. The # of games played with at least one clanmate

2. The most recent game played with at least one clanmate

[Note: Double check how expensive it is to check clan membership from a PGCR, if it is expensive make sure to cache clan memberships during query]

Wildcard Search Collections

Don't hide zero pt or invisible triumphs from "Search" or "Tracked"

Improve home screen

Use cards and show Reckoning burns etc

Filter clan by platform

Firefox Gear Not Loading

As of around a week ago, D2Checklist will no longer load in Firefox. On attempting to access the gear page, we get the minified error:

ERROR Error: "[object Object]" E https://www.d2checklist.com/polyfills.86cae2b94ad943dfc2f5.js:1 E https://www.d2checklist.com/polyfills.86cae2b94ad943dfc2f5.js:1 R https://www.d2checklist.com/polyfills.86cae2b94ad943dfc2f5.js:1 invokeTask https://www.d2checklist.com/polyfills.86cae2b94ad943dfc2f5.js:1 onInvokeTask https://www.d2checklist.com/main.9a441e523718854f0a95.js:1 invokeTask https://www.d2checklist.com/polyfills.86cae2b94ad943dfc2f5.js:1 runTask https://www.d2checklist.com/polyfills.86cae2b94ad943dfc2f5.js:1 v https://www.d2checklist.com/polyfills.86cae2b94ad943dfc2f5.js:1 invokeTask https://www.d2checklist.com/polyfills.86cae2b94ad943dfc2f5.js:1 y https://www.d2checklist.com/polyfills.86cae2b94ad943dfc2f5.js:1 b https://www.d2checklist.com/polyfills.86cae2b94ad943dfc2f5.js:1

It seems rather unlikely the a polyfill would be crashing here, but I suppose it is possible. The gear page itself does not show any content, and the page sets the route to www.d2checklist.com/home.

CSV export Triumphs

https://www.reddit.com/r/destinychecklistnet/comments/bn5ozv/export_triumphs/

Support shard mode on items from postmaster

Right now fails with "item not found"

Incorporate Season of the Drifter God rolls

PandaPaxxy released a new set of lists: https://www.reddit.com/r/CruciblePlaybook/comments/ay2jk6/season_of_the_drifter_weapons_breakdown_and/

DarkElement published a gist of that here: https://raw.githubusercontent.com/darkelement1987/godroll/master/drifter_recommendations_panda.txt

Look into adding weekly XP earned to clan report page

Could this be a decent proxy for how active a player is?

Some godrolls missing that show up in DIM with same gists

See more info here: https://old.reddit.com/r/DestinyTheGame/comments/aye6mq/mega_wish_list_for_destinyitemmanager/eij2hqb/

Workaround Bungie gear lock bug on Shard Mode

There is a known Bungie API bug (Bungie-net/api#764) that can cause items to be locked when moved out of the vault. This can make "Shard Mode" a pain. Shard Mode should recover from these unexpected locks automatically.

Report Gambit Prime and Reckoning weekly milestones

API doesn't report it yet, I don't think. May have to get cute to grab it.

Badges

Build them into the collections screen, in a perfect world also hot link to them from associated Triumphs

Sign in issue with BNET as preferred platform

https://old.reddit.com/r/destinychecklistnet/comments/bfvgbz/d2checklist_tech_refactor_let_me_know_if_you_see/emf95e1/

Support ! filter on gear mgr

https://www.reddit.com/r/destinychecklistnet/comments/bqbxho/using_not_to_find_any_weapons_or_armor_that_does/

Report weekly XP in clan csv file

Forgot to add this part to the CSV export

Support mulit-item reddit copy/paste at https://www.d2checklist.com/gear

Currently you can copy a single item in MarkDown format, to easily paste it's perks to reddit:

Add a new button to the top of the list that will copy all items matching the current filter to the clipboard (limited to a max of X b/c we don't want to spam up someone's clipboard with 400 items, do we?)

X = 20 for now

Wishlist bug?

https://old.reddit.com/r/destinychecklistnet/comments/av5d2t/d2checklist_pvp_vs_pve_god_rolls/elj0crj/

Fix postmaster items on item compare

Show "RECOMMENDED PVP/PVE" tooltips on godroll perks

Display Clan membership next to profile info

Display on main player profile page:

Display on recent teammates page:

Filter gear by tag rather than string match

Currently filtering is a simple string match. Filtering by individual queries works great but something like "godroll bow" won't work. String matches should be tokenized.

Allow transfer and equip from comparison screens

Support "secondary" "heavy" ammo queries in gear manager

Utilize new Gambit Prime and Reckoning data in milestones

Bungie-net/api#889

Add Destiny fonts, specifically vanguard for flagging PVE perks

Mark active filters in Gear Mgr

Currently there is no visual indicator if you're filtering on a category. Add one

Properly report Gambit Prime, Reckong and Forge

Don't show "Unknown66" etc

"Copy all for reddit" changes

Use "1. 2. 3." instead of "1) 2) 3)". Only number items if more than one item is selected for.

Show complete triumphs as 100%

In searchable/tracked triumphs there can be a weird state (like on "Superstar") where a completed triumph shows 0%. Instead force it to 100%.

Differentiate between unavail and avail collection items

https://www.d2checklist.com/1/adeese/collections;id=1186584658

Handle postmaster items in gear mgr

Right now we're ignoring them b/c they can't be fully manipulated. Enhance things to actually be able to mark them and grab them.

Hide Triumphs from closest Triumphs list

https://old.reddit.com/r/DestinyTheGame/comments/bjmwnf/d2checklist_target_armor_perks_and_god_roll_guns/em9ix0b/?context=3

Custom track triumphs

Allow users to mark a triumph, probably from the "search" tab as tracked and show it in a new "Tracked" tab at the end.

Handle postmaster items in gear mgr

Post master items should be ignored in the Gear Mgr (folks can use DIM or something else for that if they want). Right now they're treated as normal items and get errors.

godrollpvp/godrollpve swapped

Image speaks for itself :-)

Display Modifiers on profile page

Take this info:

And show it on a button here with a modal popup:

Consider feasibility of i18n

Investigate reporting Spider's weekly bounty

Perhaps there are some cute things I could do with the vendor endpoint to figure out if that remains to be done.