dc2011 / td Goto Github PK

Sometimes when exiting the program the audio sometimes gives off an error.

I think this has to do with context being destroyed before the streamOgg() exits so it calls checkError();

tstenvold to fix

This is a reminder to fix if something funky happens in Nickhuber/master

The Player's name won't display unless you're moving and won't disappear unless you move after you've pressed/held the key to display them. Probably an issue with setting the object dirty and updating the image.

This will probably be an issue with the healthbars, too.

Currently there is not animation for network players

Build menu is working great!
However when I select option 2, cannon ball is missing.

I run the client, and close the lobby window without clicking any other buttons. The window closes but the program does not actually exit.

gdb tells me that we are waiting somewhere in AudioManager::streamVoice...

Some projectiles don't stop when they reach their destination

Sound crashes with an "Invalid Value" after an unknown amount of time.

Check if the buffers are being free'd

Player moves faster in diagnal then he does in any straight direction

At some point, this functionality was lost. Fix it!

Server will send this message correctly, but I'm pretty sure the client just dies.

Game occasionally segfaults when shutting down on removeUnit()

Build menu does not disappear after its a selection has been made

Projectiles that have reached the end of their path, sometimes jiggle in place.

Someone that likes math can try to figure out how to use this value properly

When opening a context menu, the only way to close it is to build a tower. The space bar does not close the menu.

Sound crashes with an "Invalid Value" after an unknown amount of time.

Check if the buffers are being free'd

This seems to only be an issue when connected to the server.

NPCs sometimes go past the base, then return to a random waypoint and follow the path again. Usually they eventually die off when they reach the base again.

Pretty sure this is what was occurring earlier today:

pure virtual method called
terminate called without an active exception
Program received signal SIGABRT, Aborted.

Backtrace: https://gist.github.com/906893
Occurred on dc2011/master with dvpdiner2/master merged in.

Once the wave parsing is fully implemented, the SDriver should send a kGameOver message.

Only on OSX, the buildable locations, and base location are showing a black background instead of being transparent.

At some point in the initialization phase of the game we need to call something like

QThreadPool::globalInstance()->setMaxThreadCount(n);

Where n is the number of foreseeable threads we will need across the game.
This is particularly important as the audio starts a new thread for every playSound() function call.

Otherwise QtThreadPool max is set to the "Ideal" size which may not be ideal for us

If keys are hit fast or too much is going on sometimes the menu can scale larger than it should.

Holding the r key does not display NPC health bars.

I am thinking possibly in the README?

on Linux if you move off the Map, minimize the game, then bring it back the map will be scrolled. If you press 'f' to fire something you will crash.

If the map has a route to leave the viewable area, and the player tries to escape in that route then the game crashes.

The collision detection should check the bounds of the viewable area and not allow the player to leave it.

Mac OS gets random crash any time btwn 30 seconds - 5mins of playing.
Seems to be related to firing projectiles..
Feels like a threadsafe issue.

Relevant crash log details:

Thread 0 Crashed:  Dispatch queue: com.apple.main-thread
0   libSystem.B.dylib               0x00007fff845aa616 __kill + 10
1   libSystem.B.dylib               0x00007fff8464acca abort + 83
2   libstdc++.6.dylib               0x00007fff8224d5d2 __tcf_0 + 0
3   libstdc++.6.dylib               0x00007fff8224bae1 __cxxabiv1::__terminate(void (*)()) + 11
4   libstdc++.6.dylib               0x00007fff8224bb16 __cxxabiv1::__unexpected(void (*)()) + 0
5   libstdc++.6.dylib               0x00007fff8224bfd6 std::bad_cast::what() const + 0
6   com.yourcompany.client          0x000000010001277d GraphicsComponent::initGraphicsComponent() + 33 (GraphicsComponent.cpp:82)

This was seen in a network session with two players.
In a network session, only the local player has a valid PhysicsComponent, all other players have a NULL PhysicsComponent. It appears that effects are being applied to all players, and crashing trying to set the velocity of a NULL component.

GameObject::getPhysicsComponent(); Getting null pointer

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xb4c89b70 (LWP 24898)]
0x08062a5c in td::PlayerTerrainSlowEffect::apply (this=0x856c950)
    at engine/EffectTypes.cpp:45
45      ((PlayerPhysicsComponent*)(unit_->getPhysicsComponent()))->setMaxVelocity(velocityChangeValue_);
(gdb) p unit_->physics_
$1 = (td::PhysicsComponent *) 0x0
(gdb) bt
#0  0x08062a5c in td::PlayerTerrainSlowEffect::apply (this=0x856c950)
    at engine/EffectTypes.cpp:45
#1  0x0806236d in td::Effect::update (this=0x856c950) at engine/Effect.cpp:45
#2  0x08088d86 in td::Effect::qt_metacall (this=0x856c950, 
    _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0xb4c88b7c)
    at ../moc/moc_Effect.cpp:78
#3  0x08088ff8 in td::PlayerTerrainSlowEffect::qt_metacall (this=0x856c950, 
    _c=QMetaObject::InvokeMetaMethod, _id=6, _a=0xb4c88b7c)
    at ../moc/moc_EffectTypes.cpp:162

(Reminder to myself)
The game server does not detect when a player has disconnected.

It should send a deletion message to all remaining players to remove that player from the game.
If there are no remaining players, the server thread should terminate gracefully.

I got a segfault after three shots. Possibly due to it not being disconnected.
https://gist.github.com/921197

If you walk into a wall and try to redirect, you have to wait a bit for the velocity towards it to bleed off before you can move again. Same with walking at an angle along a wall. You'll occasionally jump along it, but mostly just get stuck there.

These aren't used anywhere (QPolygon is used instead), and since they are also largely unfinished they should be removed to prevent confusion.

After the first NPC wave has spawned, closing the game causes a segfault.

After building a tower, remnants of the context menu are sometimes left on the screen.

If I start the client, I need to click within the window before arrow keys have any effect.

When started from the terminal, the terminal window retains focus (evidenced by [[A [[C being printed when arrows are pressed).

This might not be an issue once we have a start menu that requires mouse interaction.

Sometimes when facing diagonally the orientation has trouble deciding its value.

When moving from a slowing tile to a speeding tile, the player will remain slow on the speeding tiles.
When moving from a speeding tile to a slowing tile, the player will remain speedy on the slowing tiles.

If you are moving a player and tap the opposite direction while holding down the other key the player stops movement fully.

IE
Holding left key
Tap right Key

Player is stuck until either left key is released or right key is pushed again (although this has the same effect as the first time if you don't release the left key)

If there are a lot of overlapping objects the game laggs.

IE tons of projectiles and the player runs over them it laggs badly.

Player moves right without input at start of game.

Get this error upon start of client:

X Error: BadWindow (invalid Window parameter) 3
Major opcode: 31 (X_GrabKeyboard)
Resource id: 0x0

Upon closing (pressing the x button) the client does not end.

Appears that a deleted NPCGraphicsComponent still occasionally gets showDamage() called on it. Backtrace below:
https://gist.github.com/918285

Resources are created in the Map class, which means they don't have the Driver as a parent, which leads to crashes if they ever call update().

Right now the call to update() is commented out, but ideally the resource initialization should be moved.

This is mostly a reminder for me (Tom).
We currently only initialize the 1st path layer in Map::initMap().
The code also seems to assume that paths are tied to a specific NPC type.
This will need to be reimplemented to allow for varying number of NPC paths which do not assume NPC type.

It looks like the script / NPCWave / NPCInputComponent::initWaypoints() code will need to be reviewed to make sure it is also compatible with this.

(Reminder to myself)
If two game servers are spawned, they have the same multicast IP. The IP should increment with each server spawned.

When an NPC is hit, it shows their health before they take the damage briefly, before it shows their actual health.

If I run up+right and tap space repeatedly, the context menu opens as expected.

Any other combination of diagonals (up+left, down+left, down+right) seems to result in the menu not opening (tapping spacebar has no effect).

Here is a gdb dump

https://gist.github.com/914245

We need the menu to open above all other images on the screen.

Currently it opens underneath the towers a NPC's