dblock / slack-sup

Slack bot that generates fresh triads of team members to meet every week in an informal standup, or S'Up.

S'Up for Slack

What's This?

The most valuable relationships are not made of two people, they’re made of three. A third person will always stabilize and grow the relationship between the other two. It’s called a triad, and the more you create, the stronger your network.

This bot passively generates fresh triads of company members to meet every week in an informal standup, or S'Up.

Install

We host the bot at sup.playplay.io.

History

S'Up for Slack is made possible with the generous support of team Artsy. This is a fresh rewrite of artsy/sup for Slack teams during ArtsyOpenSource Hackathon 5.0.

Copyright & License

Copyright Daniel Doubrovkine, Vestris LLC, 2017-2019

MIT License

slack-sup's Issues

Help triads create gcal or other calendar items

Probably connect to Google as explained in https://developers.google.com/google-apps/calendar/quickstart/ruby via a DM, then create a calendar item that people can edit themselves? Or a link where they can add themselves? Or a link to a page that uses gcal API to create a calendar item (https://developers.google.com/google-apps/calendar/quickstart/js)?

Suggest a sup for other people

@sup suggest @dblock @orta talk about the weather

If these had met recently

@dblock and @orta met 3 days ago in a S'Up, are you sure you want to recommend they meet again?
[ yes ] [ no ]

DMs these two

Hey @dblock and @orta! @joe is suggesting you meet for 20 minutes and talk about the weather.

Once the status is updated, notifies the person who suggested the sup.

Thanks for letting me know, and thanks for suggesting this S'Up @dblock!

Add a button that a user can click to avoid dealing with popups

Instead of A popup has been blocked by the browser. Please enable popups for GCal to work and reload this page., show a button that a user clicks.

Allow admins to opt in/out a specific user

Without disabling a user in slack, allow admins to opt in/out someone.

Make the onboarding experience more engaging

When you install S'Up it DMs slack admins with

Hi there! I'm your team's S'Up bot. Thanks for trying me out. Type help for instructions. I plan to setup some S'Ups via Slack DM next Monday.

Then, next Monday it sets up triads.

This seems underwhelming for an on-boarding experience, since you just sit and wait till Monday AM to get triads setup.

What else can you do?

Change Create Event button after gcal was created to Click to See Event

Nudge DMs that have seen no activity after a couple of days

If a DM was sent to a bunch of people, nudge them if there're no new messages in the channel.

Improve generation of sets of 3

See jimwise/ambit#1 (comment)

Add a note when people's timezones don't match up

I got in a sup with someone from the UK (GMT) NYC (GMT + 5) and LA (GMT - 8) which is obviously bit tricky.

Maybe we can help let people know about a good time via by having sup pass a link like: https://www.timeanddate.com/worldclock/meetingtime.html?iso=20171106&p1=179&p2=136&p3=137

Customize all team messages

Teams should be able to set the sup message and the reminder messages.

Set team timezone

Set and use team timezone so that sup happens on the correct day of the week.

Introduce a new hire to a few people

Set up a list of intros over Slack for a new hire during their onboarding period. Ideally to a group of people. A subset of #28

When your subscription expires, we tell you about it a few too many times

Allow customizing how many people meet at a time per team

There's no reason not to do 2 people or 4, except the mission of this bot. But the option is nice.

Creating calendar items requires auth with gcal and popups, doesn't report failures

Failures in auth aren't properly reported. Need to direct people to popup questions and properly handle failures.

Update_cc spec fails in CI

https://travis-ci.org/dblock/slack-sup/builds/266181097

 1) Update cc with a stripe key a team with a stripe customer ID updates cc
     Failure/Error: find('#update_cc', visible: false)
     
     Capybara::ElementNotFound:
       Unable to find css "#update_cc"
     # ./vendor/bundle/ruby/2.4.0/gems/capybara-2.15.1/lib/capybara/node/finders.rb:313:in `block in synced_resolve'
     # ./vendor/bundle/ruby/2.4.0/gems/capybara-2.15.1/lib/capybara/node/base.rb:85:in `synchronize'
     # ./vendor/bundle/ruby/2.4.0/gems/capybara-2.15.1/lib/capybara/node/finders.rb:302:in `synced_resolve'
     # ./vendor/bundle/ruby/2.4.0/gems/capybara-2.15.1/lib/capybara/node/finders.rb:37:in `find'
     # ./vendor/bundle/ruby/2.4.0/gems/capybara-2.15.1/lib/capybara/session.rb:776:in `block (2 levels) in <class:Session>'
     # ./vendor/bundle/ruby/2.4.0/gems/capybara-2.15.1/lib/capybara/dsl.rb:50:in `block (2 levels) in <module:DSL>'
     # ./spec/integration/update_cc_spec.rb:37:in `block (4 levels) in <top (required)>'
     # ./spec/support/database_cleaner.rb:15:in `block (3 levels) in <top (required)>'
     # ./vendor/bundle/ruby/2.4.0/gems/database_cleaner-1.6.1/lib/database_cleaner/generic/base.rb:16:in `cleaning'
     # ./vendor/bundle/ruby/2.4.0/gems/database_cleaner-1.6.1/lib/database_cleaner/base.rb:98:in `cleaning'
     # ./vendor/bundle/ruby/2.4.0/gems/database_cleaner-1.6.1/lib/database_cleaner/configuration.rb:86:in `block (2 levels) in cleaning'
     # ./vendor/bundle/ruby/2.4.0/gems/database_cleaner-1.6.1/lib/database_cleaner/configuration.rb:87:in `cleaning'
     # ./spec/support/database_cleaner.rb:14:in `block (2 levels) in <top (required)>'
  2) Update cc with a stripe key a team without a stripe customer ID displays error
     Failure/Error: find('#update_cc', visible: false)
     
     Capybara::ElementNotFound:
       Unable to find css "#update_cc"
     # ./vendor/bundle/ruby/2.4.0/gems/capybara-2.15.1/lib/capybara/node/finders.rb:313:in `block in synced_resolve'
     # ./vendor/bundle/ruby/2.4.0/gems/capybara-2.15.1/lib/capybara/node/base.rb:85:in `synchronize'
     # ./vendor/bundle/ruby/2.4.0/gems/capybara-2.15.1/lib/capybara/node/finders.rb:302:in `synced_resolve'
     # ./vendor/bundle/ruby/2.4.0/gems/capybara-2.15.1/lib/capybara/node/finders.rb:37:in `find'
     # ./vendor/bundle/ruby/2.4.0/gems/capybara-2.15.1/lib/capybara/session.rb:776:in `block (2 levels) in <class:Session>'
     # ./vendor/bundle/ruby/2.4.0/gems/capybara-2.15.1/lib/capybara/dsl.rb:50:in `block (2 levels) in <module:DSL>'
     # ./spec/integration/update_cc_spec.rb:57:in `block (4 levels) in <top (required)>'
     # ./spec/support/database_cleaner.rb:15:in `block (3 levels) in <top (required)>'
     # ./vendor/bundle/ruby/2.4.0/gems/database_cleaner-1.6.1/lib/database_cleaner/generic/base.rb:16:in `cleaning'
     # ./vendor/bundle/ruby/2.4.0/gems/database_cleaner-1.6.1/lib/database_cleaner/base.rb:98:in `cleaning'
     # ./vendor/bundle/ruby/2.4.0/gems/database_cleaner-1.6.1/lib/database_cleaner/configuration.rb:86:in `block (2 levels) in cleaning'
     # ./vendor/bundle/ruby/2.4.0/gems/database_cleaner-1.6.1/lib/database_cleaner/configuration.rb:87:in `cleaning'
     # ./spec/support/database_cleaner.rb:14:in `block (2 levels) in <top (required)>'

Works locally. Weird.

Customize how often S'Up is run

Some teams want a sup every week (current implementation), others want it less frequently.

nil can't be coerced into Integer

We set out to try S'Up before we would consider a subscription. Unfortunately, after the first week, S'Up only responded with "nil can't be coerced into Integer" to known commands:

For unknown commands, it's still friendly enough to say "I don't understand that command!":

Needless to say, but just to be sure: it also doesn't schedule triads anymore.

Recommend to sup next week

Recommended people meet next week instead of this week. Possibly more useful when Sup every other week.

Allow opting into/out of public API

Add optional API token for API data access

This way teams can have access to their own data.

Find a way to auto-close/hide DMs

The group DMs are accumulating...

Create S'Ups within a subteam or channel

Designate a subteam on slack to have S'Up with. Via @jessicabackus

DM users after a GCal calendar item has been created

Rate s'up individually

After someone confirms that they all met or some met, ask users to rate the sup ala Leo.

Allow customizing the hard-coded 3 weeks that makes a meeting "old"

Automatically opt out people that don't have a team field

As a part of the “don’t show people with the same team” it could also remove people who don’t have a team at all.

Via @orta

Kick off cron from inside the service

Currently manually running dokku run sup-bot rake cron:weekly

Gcal doesn't switch calendars on redirect

If you're logged into two calendars, you may get redirected to the wrong one after the gcal entry has been created.

Designate S'Up person in charge of setting up a meeting

When a new DM is created, tell one person that they are in charge of setting up the calendar. Sort people in charge such as that you're not in charge all the time.

Send the hello message to every new user upon registration

Expose sup detail into the API

Prevent S'Ups in different timezones

People in different timezones have hard time meeting. Give an option to prevent that or optimize for those in the same timezone.

Support other languages, translate messages

Fallout from #24

Give users an option to not meet certain people, such as in their team

cc: @orta, this is where we'd want team information in a custom field in slack

Opt-in via channel

This is something donut.ai does, instead of global opt-in, you join a channel and people are picked from that channel.

Secure cc update endpoint with a short lived token

Right now this just allows someone to override a tokenized cc value, which is annoying but harmless.

Wrong time shown on calendar (month instead of hour)

Give users an option to opt-out

Opt out people inactive for a very long time

I got an ex-employee who still has an account but Slack classes as being inactive, might be in the API?

Configure on which day to ask whether people have met

Automatically support users with ooo in their nicknames

Customize on which day rounds are run

Currently rounds are run once a week, as soon as a week passed. At the very least we want to know on what day S'Ups are going to be created.

Opt in/out restricted and ultra restricted accounts

Allow opting in accounts that have is_restricted=true or is_ultra_restricted=true. Currently those are excluded.

When making Sup groups, ignore those pairs that haven't all met

When making groups it's ok to re-pair people that haven't actually met (submitted feedback that they have not been able to meet).

Tell a team that has less than 3 people that they won't get any sups during onboarding

Prompt in the DM channel whether the team met and record that information

With nice buttons

Add stats

Provide summary information about sups to the teams.

Pair remaining users

If the number of users doesn't divide by 3 someone will be left out. Web sup used to pair these together.

Another option is to add them to existing sup's, therefore creating sups of 4.

DM an introductory message after registration to the registrar