Comments (15)
Awesome!! I'll give it a shot.
I notice that you have depends_on :postgresql
. Will that force an install of postgres via brew even if someone has postgres installed via a different mechanism (say PostgresApp or MacPorts)?
from pgcli.
This is true, I can try removing that dep as it may not be necessary for psycopg to build.
On Jan 7, 2015, at 5:43 PM, Amjith Ramanujam [email protected] wrote:
Awesome!! I'll give it a shot.
I notice that you have depends_on :postgresql. Will that force an install of postgres via brew even if someone has postgres installed via a different mechanism (say PostgresApp or MacPorts)?
—
Reply to this email directly or view it on GitHub.
from pgcli.
Regarding a test. Can you just do pgcli --help
?
from pgcli.
The url for pgcli seems to point to github instead of pypi. I'd probably set it to pypi (https://pypi.python.org/packages/source/p/pgcli/pgcli-0.10.2.tar.gz) so it's similar to the rest of the packages.
from pgcli.
Ohhh, looking forward to when this works properly. (:
from pgcli.
Switched to pypi and bumped to 0.10.2.
As for postgres, it is needed for psycopg2 to build, and AFAIK homebrew offers no means to check for existing/external installations outside of homebrew.
I suspect pgcli --help
will be considered insufficient by homebrew since they don't like people using pgcli --version
(as an example).
from pgcli.
I think having 'postgres' as a dependency is reasonable in this case.
I can't think of a better test than pgcli --help since this is an interactive app.
Thanks for updating the url to pypi.
Is there an automated way to compute the sha for all those packages?
from pgcli.
@tvon Will you be submitting a PR to homebrew or should I take over from here?
Please let me know.
from pgcli.
@amjith I went ahead and submitted Homebrew/legacy-homebrew#35709
There is no current means to compute the shas for the dependencies, I did it the hard way... Though it could be easily scripted.
from pgcli.
Thank you for submitting the PR.
After I asked you about the sha I went researching a little bit and found this script in the homebrew cookbook.
https://raw.githubusercontent.com/tdsmith/labmisc/master/mkpydeps
from pgcli.
I notice that you have depends_on :postgresql. Will that force an install of postgres via brew even if someone has postgres installed via a different mechanism (say PostgresApp or MacPorts)?
Two scenarios:
- If pgcli is installed from a bottle (a Homebrew-generated binary package),
depends_on :postgresql
will force an installation of Homebrew postgresql. - If pgcli is installed from source, either because Homebrew does not provide a bottle or a user passes
--build-from-source
tobrew install
, Homebrew postgresql will only be installed if there is not another postgresql in $PATH.
Most users will experience the first condition.
from pgcli.
That doesn't really answer the original question though.
If I read your reply correctly, the answer is: yes, a brew install of pgcli will force a brew installation of postgresql even if the user previously installed Postgres via other means.
Could this lead to problems? (Especially for lesser experienced users.)
from pgcli.
Ah, yes, installing pgcli will force a brew installation of postgresql.
Generally speaking I don't think this will cause problems, but here are some potential pitfalls (in rough order of likelihood):
- The brew install is in the
PATH
before the non-brew install and the user relies on the command line tools. This may or may not be an issue depending on the tools being used, but it's worth mentioning (and easy for the user to check). - The non-brew installation exists in the same place as homebrew. E.g., if the user installed homebrew by the recommended means to
/usr/local
and also has postgresql installed to/usr/local
then the postgresql installation by homebrew will fail in the final step of the installation (where it links installed files tobin
andlib
) and pgcli won't be installed. - The brew version of postgresql is protocol-incompatible with the non-brew installation. I don't think this is even currently possible (I think you can use psql 8.3 to connect to a postgres 9.4 server).
Does that answer your question?
from pgcli.
@tvon Thanks for working through the issues and addressing the requests of the homebrew maintainers.
I see that it is now merged. I'm grateful for your help and resolve in getting this done. :)
I'll update site to include the brew install method in install pages.
🎸
from pgcli.
http://pgcli.com/install is updated.
Thanks!
from pgcli.
Related Issues (20)
- Using environment variables to connect via ssh HOT 2
- pgcli 4.0 - ModuleNotFoundError: No module named 'six' HOT 7
- pgcli.magic `conn.session.engine.url` raises AttributeError after breaking change upstream in ipython-sql
- Raised notices are printed backwards HOT 3
- Segfault on MacOs HOT 2
- Doesn't work with Python 3.11/Windows HOT 6
- Tab completion not working in version 4.0.1 on macOS
- pendulum dependency cannot be installed on 32-bit arches HOT 4
- Autocomplete not working for Apache AGE extension function names HOT 1
- Boolean type always show `false` HOT 9
- `invalid input syntax for type oid: "{oid}"` when running \d on an index HOT 4
- Per-database prompt colours HOT 1
- psycopg.errors.DataCorrupted: missing chunk number 0 for toast value 16386 in pg_toast_2619 HOT 3
- Can not quit pgcli if server has shutdown
- Readme link - this page has moved HOT 1
- Document how to replace pg_isready with pgcli HOT 1
- Add types HOT 2
- error while retoring dump with zstd compreesion. HOT 1
- Unable to use `pgcli service={service}`
- Distribute binary packages when tagging new versions HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pgcli.