Coder Social home page Coder Social logo

Comments (4)

dbaty avatar dbaty commented on July 22, 2024

I wasn't even sure what it was used for and how it looked like. Here is an example:

> select pg_sleep(2)
+----------+
| pg_sleep |
|----------|
|          |
+----------+
SELECT 1
Time: 2.013s (2 seconds), executed in: 2.003s (2 seconds)

> select pg_sleep(62)
+----------+
| pg_sleep |
|----------|
|          |
+----------+
SELECT 1
Time: 62.066s (1 minute 2 seconds), executed in: 62.063s (1 minute 2 seconds)

Pendulum (that is currently used) and Humanize (which was used before, as noted by the reporter) have translations, but pgcli does not even use them (which is understandable, since the rest of the UI is in English).

It's thus a bit sad to require a third-party package for such a small feature. @j-bennet: I'm inclined to rewrite a corresponding function within pgcli (and drop the requirement on pendulum), what do you think?

Actually, I am not even sure that displaying the duration in words is that useful... What's your take on this?

from pgcli.

dbaty avatar dbaty commented on July 22, 2024

I went ahead and created a pull request (#1452) where I remove the dependency on Pendulum and replaces it by a home-made function.

from pgcli.

j-bennet avatar j-bennet commented on July 22, 2024

I went ahead and created a pull request (#1452) where I remove the dependency on Pendulum and replaces it by a home-made function.

Well done @dbaty, thanks for the quick turnaround.

from pgcli.

mgorny avatar mgorny commented on July 22, 2024

Thank you!

from pgcli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.