Coder Social home page Coder Social logo

Comments (7)

amjith avatar amjith commented on July 21, 2024

Yes it would be a useful feature and I want to do it.

It's hard to tell if it'll be easy to do or not. It'll require some parsing changes to parse_utils file.

https://github.com/amjith/pgcli/blob/master/pgcli/packages/parseutils.py#L11

You're welcome to take a stab at it.

from pgcli.

qwesda avatar qwesda commented on July 21, 2024

hi,
i submitted a pull request (#83) that adds double quote escapes for table/column names with spaces, symbols, non-ascii chars and mixed-cased letters.

from pgcli.

amjith avatar amjith commented on July 21, 2024

PR #83 overlaps with this feature request. It add auto-escaping to the columns/tables that are keywords or Uppercased or spaces. But it doesn't do auto-completion if the user opens a double quote.

So I'm leaving this issue open to track that feature. :)

Cheers!

from pgcli.

qwesda avatar qwesda commented on July 21, 2024

Hi,

yes I noticed this too but I wasn't sure what had to changed. Maybe just the cleanup_regex in parseutils.py?
If it's something that requires more work you could give me some pointers an i'll look into it ... but maybe your quicker doing it yourself.

from pgcli.

amjith avatar amjith commented on July 21, 2024

I think it should be a as simple as adding/removing stuff in the cleanup_regex.

I haven't had time to deep dive into the code since I announced it. Barely keeping up with reviewing PRs and answering Issues. You're welcome to take a stab at it, otherwise I hope to spend some time this weekend to work on it. :)

Cheers!

from pgcli.

amjith avatar amjith commented on July 21, 2024

This commit afef77a fixes the auto-completion for quoted tables/columns that are auto-escaped.

from pgcli.

amjith avatar amjith commented on July 21, 2024

This is now released in v0.12.0.

https://pypi.python.org/pypi/pgcli/0.12.0

from pgcli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.