[Bug] Cheatin' Straight about doomtown-reloaded-octgn

[db0]

It could be one of the cards has the wrong value in the game. Which cards did you have?

[Khudzlin]

I'm not sure exactly, but I can narrow it down: the 9 might be Dr Dawn Edwards, Xiong "Wendy" Cheng, Jarrett Blake or Cheatin' Varmint (possibly Bunkhouse, Morgan Research Institute or Mechanical Horse), the 8 might be Lane Healey, Pat's Perch, Cattle M Ranch or Force Field and the 7s might be Pinto or Auto-Revolver (possibly James Ghetty, Arnold McCadish, Androcles Broklehurst, Blake Ranch, Cattle Market, Run 'em down or Pinned Down).
All of those cards have the correct rank and suit in the deckbuilder. I looked specifically for 7s and 9s in the deckbuilder when making the deck (a 7 would be the likely culprit under your scenario),

[Khudzlin]

After some thinking, I've come to the conclusion that the issue cannot be caused by an incorrect value. If one of the 7s was counted as a 5, 6, 10 or J, the hand would be a legal straight rather than a cheatin' one. Straights (like Dead Man's Hands, Straight Flushes and High Cards) are never cheatin', because they cannot possibly have 2 cards with the same value.

[db0]

hm, yeah, you're right.

[Khudzlin]

I have an idea about how to detect straights: determine the highest (h) and lowest (l) natural ranks (excluding jokers, and converting A to 1, J to 11, Q to 12 and K to 13, like for pulls) occuring in the hand and the number of jokers (j); the hand is a straight if h - l < 5 and h - l + j >= 4. For lowball, ignore the jokers and just check h - l = 4.

[Khudzlin]

I've seen it again with General Store (Q of D), 2x Hex Slinging (J of C), Avie Cline (10 of S) and the Black Joker.

Shootout hand is 5: Straight (Cheatin'!) (10 Spades, Queen of Diamonds, Jack of Clubs, Jack of Clubs, Joker).

[Khudzlin]

The problem is that numrank treats jokers as kings, giving them rank 13. So they need to be excluded when checking for straights. To avoid having jokers being treated as both jokers and kings, the while condition in straightchk needs to be changed to

while i < 4 - jokers: