dazzlingfugu / ember-feature-controls Goto Github PK

Features values are not correctly restored by instance-initializer when ember-local-storage is used with namespace or keyDelimiter options.

The reason is :

feature-controls component uses storageFor from ember-local-storage to write values in locale Store (https://github.com/peopledoc/ember-feature-controls/blob/master/addon/components/feature-controls.js#L6).
storageFor take into account the ember-local-storage config to write the key at the right place in locale storage (with correct namespace and/or delimiter).

In other hand, the instance initializer uses getStorage & get value with the storage:feature-controls key wich does not take into account the ember-local-storage config (https://github.com/peopledoc/ember-feature-controls/blob/master/addon/instance-initializers/load-feature-controls.js#L9)

It results with a desynchronisation between ember-feature-controls & ember-feature-flags as the value are not correctly restored onto ember-feature-flags features service.

Feature controls components:

• showRefresh option
• showReset option
• refresh button action
• reset button action

This addon is so convenient for development, but I would like it to be unavailable in production and not constribute to distro size.

We will need to delete the resolution deps of clean-css when ember-cli will upgrade his deps to ember-cli-preprocess-registry v4.x.x because it doens't use it anymore

//package.json "resolutions": { "clean-css": "^4.1.11" }

it could also bring new issue with node.js 12
see: ember-cli/ember-cli-preprocess-registry#71

Proposal to allow user to have control on whenever controls route is present.