dazzlingfugu / ember-cli-embedded Goto Github PK

See the release notes:

• https://github.com/ember-cli/ember-cli/releases/tag/v4.5.0

And the relevant pull request:

• ember-cli/ember-cli#9825

Because we rely on this add-on we will need to add a warning.

The problem we have with passing configuration to ember-cli-embedded is that all code references have to be changed which access config/environment.js.

const embeddedConfig = container.lookup('config:embedded');

The problem is that config:embedded is only available when ember-cli-embedded is enabled, meaning it can't be environment specific.

We've ended up doing plain ember approach:

GlobalAppVar.__container__.lookupFactory('config:environment').APP.host = 'example.com'

Advantages

• app does not depend on ember-cli-embedded
• no code changes required for embedded mode

Issues

• not all config will reflect changes (e.g. rootElement does not work)

What are the advantages of introducing new configuration system with ember-cli-embedded rather than using existing one?

Currently, projects which use this plugin are not able to be on Ember 2.15+.

Some code migration has to be done.

Thanks in advance :D

DEPRECATION: The initialize method for Application initializer 'ember-cli-embedded' should take only one argument - App, an instance of an Application. [deprecation id: ember-application.app-initializer-initialize-arguments] See http://emberjs.com/deprecations/v2.x/#toc_initializer-arity for more details.

Stop using config:embedded as a configuration store and instead add a key to config:environment, such as APP.embedded = { /* my config */}

Is there an example app where this is running?

I did a production build of my app, then opened dist/index.html in the browser and got the following error:

Uncaught ReferenceError: define is not defined

Versions:
"ember-cli": "1.13.15",
"ember": "2.3",
"ember-cli-embedded": "0.3.1",

Context:
The entire app will be embedded into webpages through a chrome extension (as a sidebar).

Trying to use addon with basically an empty ember 4.4 app and I'm getting this error:

Uncaught TypeError: Cannot read properties of null (reading 'register')
    at emberCliEmbeddedStart (embedded.ts:112:14)

I'm going to poke around and see what I can do. I'll pick my co-worker's brain when she gets back too.

I installed ember-cli-embedded after installing Ember 4.10, and I’m starting to see this deprecation warning in the console regards Ember.String:

DEPRECATION: Using `Ember.String` is deprecated. Please import methods directly from `@ember/string`. [deprecation id: ember-string.from-ember-module] This will be removed in ember-source 5.0.0. See https://deprecations.emberjs.com/v4.x/#toc_ember-string-from-ember-module for more details.
    @http://localhost:4200/assets/vendor.js:23477:17
    raiseOnDeprecation@http://localhost:4200/assets/vendor.js:23381:13
    @http://localhost:4200/assets/vendor.js:23477:17
    handleDeprecationWorkflow@http://localhost:4200/assets/vendor.js:56307:13
    @http://localhost:4200/assets/vendor.js:23477:17
    deprecationCollector@http://localhost:4200/assets/vendor.js:56342:9
    @http://localhost:4200/assets/vendor.js:23477:17
    @http://localhost:4200/assets/test-support.js:6076:15
    @http://localhost:4200/assets/vendor.js:23477:17
    invoke@http://localhost:4200/assets/vendor.js:23486:23
    deprecate@http://localhost:4200/assets/vendor.js:23454:28
    deprecateStringUseOnEmberModule@http://localhost:4200/assets/vendor.js:51126:51
    get@http://localhost:4200/assets/vendor.js:51141:38
    initialize@http://localhost:4200/assets/redacted.js:35895:36
    @http://localhost:4200/assets/vendor.js:24028:31
    @http://localhost:4200/assets/vendor.js:49389:11
    @http://localhost:4200/assets/vendor.js:49318:16
    @http://localhost:4200/assets/vendor.js:49263:26
    @http://localhost:4200/assets/vendor.js:49269:16
    _runInitializer@http://localhost:4200/assets/vendor.js:24052:20
    runInitializers@http://localhost:4200/assets/vendor.js:24026:27
    _bootSync@http://localhost:4200/assets/vendor.js:20514:29
    boot@http://localhost:4200/assets/vendor.js:20484:23
    @http://localhost:4200/assets/test-support.js:6362:32
    promiseReactionJob@[native code]

I haven’t used String anywhere in my app, and therefore I conclude this package is to blame.

Currently, the main features of this addon are:

• MyApp.start(config)
• container.resolve('config:embedded')
• container.resolve('service:embedded')
• Merge the configs into config/environment.APP
• Coerce the embedded config for backward compatibility

There must be a discussion (or better, a migration path) towards simplifying it.

How do I pass rootElement configuration to embedded app?