davorb / contestjoe

A discord bot counting the most upvoted post during the month in a channel

I'm Davor, a software developer. I make things for the web most days. Sometimes I do system programming too. I wrote Lisp and Haskell for years. Not much anymore. Now it's JavaScript, TypeScript, Ruby. They have libraries for everything. It's practical. I ship fast. For my own projects, I still use functional languages occasionally.

• Find me at [email protected] or on Twitter @davorb89.

contestjoe's Issues

Code Review

I'm not particulary familiar with the API that Discord provides, and also JS is not my favourite language to code in (I'm more backend experienced in Go, Java, Kotlin etc).

However, I've got some questions that maybe need thinking about, or feel free to ignore/correct me.

[Questions]

• Line 38 : Can I check. So, this is going to retrieve ALL messages in the channel? My concern is that we a fetching stuff we don't need, and it will get slower and slower over time. Is there a way we can add a predicate/where clause/filter on the fetching of messages?
• Line 3 : We count number of 🔥 reactions. What happens if there are these emoji on a post that doesn't contain a photo image?
• Line 65-67 : What happens if there are equal votes? (Joint 1st, etc etc)

[Nitpick]

• Why is this called "Ping"? Seems misnamed. OK, I'm being real picky now. https://github.com/davorb/contestjoe/blob/master/commands/fun/ping.js