davisvaughan / almanac-old2 Goto Github PK

At the moment on_day() is an alias of on_yday(). I'm not sure this is a good idea.

People will likely understand on_yday(), on_wday(), on_mday() and on_qday(). But I think there is likely to be a variety of intuitions about to which of these on_day() corresponds. For this reason I think it's better to nudge people into being explicit as to which day they mean by not having the on_day() function at all.

This is further complicated by the fact that lubridate::day() is an alias for lubridate::mday() and not lubridate::yday(), so there may be some further confusion caused there.

event_next() event_previous() sch_next() sch_previous()

n argument for the number of occurrences to look forward/back

I don't think we currently have anything that can say "the first day of the year, repeated 3 times, then stop"

https://www.kanzaki.com/docs/ical/rrule.html

Maybe a vignette of this