davisonio / darkage Goto Github PK

I recommend replacing all that ore generation code with the Ore Generation API, there are now several types of oregen to choose from. This will increase mapgen speed and reduce Lua lag on a server. This will also remove OOM crashes.

In recent minetest-dev because of various light glitches and crashes light_source can only be 14 and below.
Quote:

        light_source = 0, --[[
        ^ Amount of light emitted by node.
        ^ To set the maximum (currently 14), use the value 'minetest.LIGHT_MAX'.
^ A value outside the range 0 to minetest.LIGHT_MAX causes undefined behavior.]]

Dark age lamp uses 18, this crashes minetest for some people on newest minetest-dev.

https://github.com/davisonio/darkage/blob/master/nodes.lua#L226
https://github.com/davisonio/darkage/blob/master/nodes.lua#L356

Probably should add these

Should create some for the bricks

Hello,

Does this mod have a pre-generated colours.txt for this mod? I'd like to add it to my existing colours.txt to quieten all these unknown node messages I keep getting :P

Suggested by Krock, we should add a locked box.

We should use minetest's API for most of the map generation. Would be easier and more conventient. Suggested by Sokomine.

I have a subgame that I profiled for some troubles, it has darkage mod, lua mem usage at 20-90 mb (print(collectgarbage("count")/1024), it lets me generate blocks for some time and then suddenly stops at "local data = vm:get_data()" step with "Lua: OOM error from mod 'darkage' in callback environment_OnGenerated(): not enough memory". Removing darkage makes server stable, mem use below 40mb at most without oom.

No OOMs on clean game though, I'm still investigating the issue :/

On a side note I noticed pretty damn suspiciously high usage of cpu by this mod even in passive mode:

 instrumentation                                         |    min µs |    max µs |    avg µs | min % | max % | avg %
-------------------------------------------------------- | --------- | --------- | --------- | ----- | ----- | ------
darkage:                                                |         0 |     54099 |        29 |   0.0 |  99.9 |   0.1
  - on_generated[1] ...................................  |     43797 |     54099 |     48948 |  99.6 |  99.9 |  99.7