Coder Social home page Coder Social logo

[BUG] Is using inject_P() to send commands to the command buffer from the anycubic_TFT.cpp file actually the right way to do this about marlin-ai3m-2.0.x HOT 4 OPEN

davidramiro avatar davidramiro commented on August 16, 2024 1
[BUG] Is using inject_P() to send commands to the command buffer from the anycubic_TFT.cpp file actually the right way to do this

from marlin-ai3m-2.0.x.

Comments (4)

github-actions avatar github-actions commented on August 16, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label / comment or this will be closed in 5 days.

from marlin-ai3m-2.0.x.

davidramiro avatar davidramiro commented on August 16, 2024

Sorry, this should not have been closed. Some GitHub workflows were pulled from upstream that are a bit too quick for this repo.

I have merged your ExtUI repo code onto a new branch of this repo. CI reports that it wouldn't compile yet, will look into that later on.

from marlin-ai3m-2.0.x.

hub-jba avatar hub-jba commented on August 16, 2024

I have it compiling and working with absolute minimal changes to actual bugfix2.0 branch of Marlin.

Currently it's one change in the m125 code to wait for confirmation if using extensible UI.

I am still tweaking the pause/timeout/resume behaviour as well as the filament runout behaviour, but everything else is working fine.

from marlin-ai3m-2.0.x.

hub-jba avatar hub-jba commented on August 16, 2024

On this particular issue much of the marlin code uses inject_P to inject commands around the pause functionality so i think it's okay to close this. There are also enqueue and enqueue_now methods, but since the rest of the code base uses inject_P we should be good.

from marlin-ai3m-2.0.x.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.