davidctj / react-plotlyjs-ts Goto Github PK

Hi there -- great project! I just noticed that I'm being required to specify all of the layout props to the PlotlyChart element. Should the config and layout` props be Partials?

There's the warning in the console when this component is used

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

• Move data fetching code or side effects to componentDidUpdate.
• If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
• Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: PlotlyChart

Hi! It seems that current latest version of the package in master (2.2.1 after merging PR #6) isn't published to npm repo as it has only 2-year-old 2.1.0 with "latest" tag on it.

I'm using it in one of my projects and at some point additional plotly event handlers ("plotly_legendclick", etc.) were required. They aren't available in 2.1.0, although were added by PR #4 and current master have them all. Sadly, I was unable to update the package using npm. Making it possible would be very helpful :)

PS. Thanks for the convenient wrapper!

While npm install

npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.0.0" from [email protected]

Versions from package.json

"react-plotlyjs-ts": "^2.2.2",
"react": "^17.0.2",
"plotly.js": "^1.3.21",