Coder Social home page Coder Social logo

check-pages-cli's People

Contributors

davidanson avatar

Stargazers

avatar avatar

Watchers

avatar avatar avatar

check-pages-cli's Issues

bug(non-ascii): encoded Cyrillic domains

1. Summary

Both check-pages-cli and grunt-check-pages show errors if Cyrillic domains in values of the a.href attribute. Like this:

<a href="https://%D0%B6%D1%83%D1%80%D0%BD%D0%B0%D0%BB%D1%8C%D0%BD%D1%8B%D0%B9%D0%BC%D0%B8%D1%80.%D1%80%D1%84/avtor/savchenko-boris">Kira Goddess!</a>

2. MCVE

  • KiraEncodedCyrillicDomain.html:

     <!doctype html>
 <html>
     <head>
         <meta charset="utf-8">
         <title>Kira encoded Cyrillic domain</title>
     </head>
     <body>
     	<!-- [INFO] Encoded “https://журнальныймир.рф/avtor/savchenko-boris” URL -->
     	<a href="https://%D0%B6%D1%83%D1%80%D0%BD%D0%B0%D0%BB%D1%8C%D0%BD%D1%8B%D0%B9%D0%BC%D0%B8%D1%80.%D1%80%D1%84/avtor/savchenko-boris">Kira Goddess!</a>
     </body>
 </html>

3. Steps to reproduce

  1. I run http-server:

    D:\SashaDebugging\KiraCheckPages>http-server
Starting up http-server, serving ./

http-server version: 14.1.1

http-server settings:
CORS: disabled
Cache: 3600 seconds
Connection Timeout: 120 seconds
Directory Listings: visible
AutoIndex: visible
Serve GZIP Files: false
Serve Brotli Files: false
Default File Extension: none

Available on:
  http://192.168.1.2:8080
  http://127.0.0.1:8080
  http://127.0.2.2:8080
  http://127.0.2.3:8080
Hit CTRL-C to stop the server

  2. In new tab I run check-pages-cli:

    check-pages http://127.0.0.1:8080/KiraEncodedCyrillicDomain.html --checkLinks

4. Behavior

4.1. Desired

No errors.

If Latin domains, I get no errors.

4.2. Current

D:\SashaDebugging\KiraCheckPages>check-pages http://127.0.0.1:8080/KiraEncodedCyrillicDomain.html --checkLinks
Page: http://127.0.0.1:8080/KiraEncodedCyrillicDomain.html (33ms)
node:events:491
      throw er; // Unhandled 'error' event
      ^

Error: Invalid URI "https:///%d0%b6%d1%83%d1%80%d0%bd%d0%b0%d0%bb%d1%8c%d0%bd%d1%8b%d0%b9%d0%bc%d0%b8%d1%80.%d1%80%d1%84/avtor/savchenko-boris"
    at Request.init (C:\Users\SashaChernykh\AppData\Roaming\npm\node_modules\check-pages-cli\node_modules\request\request.js:273:31)
    at new Request (C:\Users\SashaChernykh\AppData\Roaming\npm\node_modules\check-pages-cli\node_modules\request\request.js:127:8)
    at request (C:\Users\SashaChernykh\AppData\Roaming\npm\node_modules\check-pages-cli\node_modules\request\index.js:53:10)
    at C:\Users\SashaChernykh\AppData\Roaming\npm\node_modules\check-pages-cli\node_modules\request\index.js:100:12
    at C:\Users\SashaChernykh\AppData\Roaming\npm\node_modules\check-pages-cli\node_modules\check-pages\checkPages.js:143:33
    at next (C:\Users\SashaChernykh\AppData\Roaming\npm\node_modules\check-pages-cli\node_modules\check-pages\checkPages.js:435:5)
    at Request._callback (C:\Users\SashaChernykh\AppData\Roaming\npm\node_modules\check-pages-cli\node_modules\check-pages\checkPages.js:314:9)
    at self.callback (C:\Users\SashaChernykh\AppData\Roaming\npm\node_modules\check-pages-cli\node_modules\request\request.js:185:22)
    at Request.emit (node:events:513:28)
    at Request.<anonymous> (C:\Users\SashaChernykh\AppData\Roaming\npm\node_modules\check-pages-cli\node_modules\request\request.js:1154:10)
Emitted 'error' event on Request instance at:
    at Request.init (C:\Users\SashaChernykh\AppData\Roaming\npm\node_modules\check-pages-cli\node_modules\request\request.js:273:17)
    at new Request (C:\Users\SashaChernykh\AppData\Roaming\npm\node_modules\check-pages-cli\node_modules\request\request.js:127:8)
    [... lines matching original stack trace ...]
    at Request.<anonymous> (C:\Users\SashaChernykh\AppData\Roaming\npm\node_modules\check-pages-cli\node_modules\request\request.js:1154:10)

Node.js v18.9.0

5. Environment

  1. Microsoft Windows [Version 10.0.19041.1415]
  2. Node.js v18.9.0
  3. check-pages-cli 0.10.0
  4. http-server v14.1.1

Thanks.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.