Comments (4)
I am open to suggestions; I added this rule because there is a chronic lack of descriptions in most specs. I want to ensure there is a check for descriptions. However, it may not need to remain a warning, it could be downgraded to info.
What would you expect from this rule if you were to define its behavior?
from vacuum.
For me personally if both summary and description were missing then it would warn, but if summary is provided and description is missing its just an info level alert that providing a description would help even more with documentation.
from vacuum.
OK, that works for me. I will update the rule for the next release. Thank you for making vacuum better.
from vacuum.
After thinking about this a little more, I made the following change: The rule will fire if there is no description AND no summary
if there is no description, but a summary is supplied, then the rule won't fire.
This is because different people use description and summary differently; some lean on one, and others lean on the other. There is no way to force people to do one or the other, so now the rule is more flexible, only to get upset if both are left out.
This update is available in v0.0.37
from vacuum.
Related Issues (20)
- Custom rule using Schema does not work HOT 2
- Required property rule sources HOT 9
- Vacuum hangs somewhere in doctor when running table tests dealing with circular references HOT 1
- Regression detecting duplicate parameters HOT 1
- Custom Vacuum rules that want resolved inputs not always resolved before running HOT 6
- False positive for oas3-unused-component rule HOT 4
- $ref in path not correctly handled in case of path parameter HOT 2
- Description warning not accurate as parsing payload HOT 1
- Invalid counting of issues HOT 1
- oas v2 rules applied to v3 spec HOT 2
- JUnit report treats all severities as failures HOT 2
- Add RateLimit to list of acceptable rate limiting headers HOT 3
- Composition with circular reference causes infinite loop HOT 4
- panic: runtime error: invalid memory address or nil pointer dereference HOT 2
- Removal of secrets present in the test files HOT 2
- "bundle" command improperly de-indents "examples:" section, resulting in invalid spec HOT 2
- [Bug/ enhancement] oas-schema-check , valid schema is set as invalid , when leveraging required + allOf HOT 2
- Dashboard highlight wrong section of file with `$ref` HOT 1
- Custom rules in golang? HOT 5
- Where is the documentation source located? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vacuum.