davenverse / epimetheus Goto Github PK

Needs a github actions work as travis is no longer operational see.

davenverse/mapref#10

http4s/http4s#2517 (comment)

Remove other constructors and just make people be explicit by default.

https://github.com/ChristopherDavenport/epimetheus/blob/efc69b90ff6f04dbdfa84504d67fecaa8c1d70a6/core/src/main/scala/io/chrisdavenport/epimetheus/Histogram.scala#L54-L57

In the function timed more specifically timedSeconds we're currently doing integer division in the case of SECONDS and truncating valuable information that would be good for the metric.

For example if start and end were: 1000 ms in and 3300 ms past then we'd have a difference of 2.3 seconds but with the current implementation we would be 1s in and then 3s in which would be 2.0 in the end result as it is currently coded.

Something like the below would fix the truncation of data problem for the default sized buckets (seconds) at least.

def timedFixed[E, F[_]: Bracket[?[_], E]: Clock, A](h: Histogram[F], fa: F[A]): F[A] =
    Bracket[F, E].bracket(Clock[F].monotonic(NANOSECONDS))
    {_: Long => fa}
    {start: Long => Clock[F].monotonic(NANOSECONDS).flatMap(now => h.observe(io.prometheus.client.SimpleTimer. elapsedSecondsFromNanos(start, now))}

• GaugeSyntaxBincompat1

#155

Was closed, doesn't seem like we fixed issue. Seems like a problem.

I figured the actual url was https://davenverse.github.io/epimetheus in the end :)

Hi,

Documentation resources mentioned in Readme is broken
https://christopherdavenport.github.io/epimetheus

404
File not found

The site configured at this address does not contain the requested file.

If this is your site, make sure that the filename case matches the URL.
For root URLs (like http://example.com/) you must provide an index.html file.

Read the full documentation for more information about using GitHub Pages

Switching to Laika has left me with a weird title approach and it looks bad.

Would appreciate the help fixing those up.

cats-effect 3.0 has reached RC state. Would be nice to provide -M or -RC build for this version. As it will contain breaking changes, I believe there will be a need to bump major version as well and adjust CI to build and publish from multiple branches.

I created a version, which builds against CE3 with this commit arixmkii@ae04eaf but it doesn't address CI and versioning in any way.

It also addresses #152 without losing ability to use different units for both Summary and Histogram.

I can provide changes as PR, when there will be separate branches for ce2 and ce3 (up to you, which one should be main for now), because obviously ce2 will be here to stay for some time.