davej / corkjs Goto Github PK

Hi,

I don't understand how to interpret the time data I get back from the api.

For CorkJS #8 it returns: 1484850600000

Side note: I have a good amount working but it's terrible code. Pretty much no js experience. Should be opening a pull request tomorrow. Hopefully you can then point out where I can improve or how things should work.

Thanks.

So continuing on from travis ci linting you mentioned in #14

How would this work? I assume it just run a linter and give a bad test result that you can view if the styling is bad? It would tell you specific line number/problem.

I was thinking maybe a "Personal projects" page could be added, so that coders can advertise what they're working on.

Hey,

A few days ago I decided to go over my commit messages and try improve them. I see that using "Add" instead of "Added" is greatly preferred on most projects.

So if I remember correctly I tried

git rebase -i HEAD~9
git push -f

I then set "reword" on most of my commits and I think one or two of yours. But when I pushed it still counts as new commits it seems? I thought rebase reword would 'rewrite history' as such? Should I still continue with this change? Or should I just drop all changes and rebase back to your master?

Sidenote: Any particular ideas for changes? I'm thinking I will add a counter for number of people attending. The upcoming tag could be 'greyed out' if it's previous?

I was also thinking of using something to remove css rules that are not being used. I used Uncss before. But I think webpack does this too? Probably in a better way? Or is that change stupid on such a small project. (Still might be good to learn for me - If there's anything difficult to webpack)

Sorry for the long issue.

A really short, simple readme could be added to explain

• What this project does
• Why it was created
• Contributors guide/How to get involved, including useful links, etc

Looks like the upcoming event is incorrect on https://cork.js.org/

I think what happened is that we pre-scheduled a years worth of events on meetup and the current algorithm is naive and just picks the event which is furthest in the future rather than the event that is next.

Shouldn't be too difficult to fix. @JammiM or @Dean-Coakley, either of ye fancy taking this on? I can review PR if ye like?

Would it be better to have a Development branch rather than users committing to the master branch ?

Api returns:
check out &lt;a&gt;<a href=\"https://cork.js.org/&lt;/a&gt\"

Which results on:
check out <a>https://cork.js.org/</a>;.
Being outputted to front end. (Visible on live site.)

I can change it to return plain text from api but looks poor with absolutely no formatting. Do you just need to make sure the link is formatted in some way (Looks like it's a link in a link at the moment) on the event? Or do I have to parse out excessive html using some js or something.

Also: Code style looks great now. Sorry about the poor style, I always use tabs/4 spaces and it was hard for me to adapt. Never considered 80 char limit but it seems to make a big difference.

Hey @davej

Planning to actually attend one at last. Just noticed the site isnt https.

https://blog.github.com/2018-05-01-github-pages-custom-domains-https/

You can do it for free here.

:)