dave-melia / text-separator

Formats a string of text and amends it with additional characters

Text-Separator

Amends a string of text with additional characters

TO-DO

Add more features
Improve design
Add 'Copy to clipboard'

Changelog

Added Regex conditioning
Code tweaks
Created functions for each separator
Added conditioning to ignore white space
Added to split() function with replace() function and changed regex to array spaces as well as new line
Added maxLength condition to stringArray to limit the input of Array elements
Minor HTML Tweaks
JS revamping
Resigned page

text-separator's Issues

Improvements to JavaScript Function

I'd suggest changing your function "change()" in "func.js" to the below instead.

(comments excluded for brevity)

• Comma seperated variable declarations rather than individual. See: https://gist.github.com/cowboy/2588448#comment-298923
• Storing the DOM element rather than just the value.
• Change to if() else if ().. to use the elements you have already retrieved from the DOM and just calling their value. No need to re-get them each time you require to use them.

function change() {
    var string_input = (document.getElementById('string_input')),
        stringArray = string_input.value.replace(/^\s+|\s+$/g, '').split(/\s+/),
        radio_comma = document.getElementById("radioComma"),
        radio_singlequote = document.getElementById("radioSingleQuote"),
        radio_dash = document.getElementById("radioDash");

    if (radio_comma.checked) {
        string_output = stringArray.join(radio_comma.value);
    } 
    else if (radio_singlequote.checked) {
        string_output = stringArray.toSingleQuotedString();
    }
    else if (radio_dash.checked) {
        string_output = stringArray.join(radio_dash.value);
    }

    document.getElementById("string_output").value = (string_output);
};