datdamnzotz / foundryvtt-game-audio-bundle-1 Goto Github PK

I get the following issue on Foundry 0.6.2.

• The entire set of bundles is rather large
• Opus is supported by all browsers modern enough to run FoundryVTT (it's part of the WebM standard)
• Opus delivers the same quality as Vorbis at lower bitrates
• Assuming you still have access to the lossless sources, it would be straightforward to re-encode them with Opus instead of Vorbis as the audio codec.

Hi,
your audio bundles currently can not be installed via the module installer in v11.

this might be the reason. you ll probably have to create a new version in the admin panel of foundry.

thanks for maintaining these modules.

Hello, and sorry for rushing earlier. I found this mod via github search for foundry vtt mods, that's how I find the new gems to install before they get announced. However, even after 1.1 the manifest link is giving me errors on 0.6.2:

Bundle 1, 2 and 4 are currently marked for v9, and 3 for v0.8.9. I've been using them without issue on v10, but a bump in capability versions and a check for anything that is getting/has been deprecated would be very welcome. Thanks for this amazing library!

Moulinette is a module that can be used to manage all kinds of different assets, including audio. It provides a very convenient interface to access files, drag them onto the scene, and create playlists from audio files. Moulinette provides a very easy way for content modules to integrate with it and it would be great if the Game Audio Bundles could do so.

The documentation about how this integration works can be found here: https://github.com/SvenWerlen/moulinette-core/blob/main/docs/README.md#how-to-index-assets-provided-by-other-modules

However, it is extremely easy, all that would be needed is to include a small JavaScript file in your module:

Hooks.once("ready", async function () {
  if(game.moulinette) {
    game.moulinette.sources.push({ type: "sounds", publisher: "Sonniss", pack: "FoundryVTT Game Audio Bundle 1", source: "data", path: "modules/gAudioBundle-1/src" })
  }
});

And of course you would need to include this JavaScript file in your module.json.

Adjust accordingly for the other bundles.

I really hope you consider adding this as it would be a tremendous help for users of both Moulinette and the Game Audio Bundles. I would also be willing to simply create a Pull Request to add this if it sounds like a good idea to you in general :)

The Audio Bundle throws the following error with vtt v11:

Metadata validation failed for module "gAudioBundle-1": Module validation errors:
  packs: 
    0: 
      type: may not be undefined

The compatibleCoreVersion inhttps://github.com/datdamnzotz/FoundryVTT-Game-Audio-Bundle-1/blob/master/module.json#L7 is still set to 0.8.0, which:

• Is a pre-release version of the 0.8.x series, not a stable release
• Is not the most recent in the 0.8.x stable series
• Is about to become a major release behind, as 0.9.x has had its third testing release

This is mostly a content module, and although it has a db file in it I'm not aware of any compatibility problems with more recent releases. Is there any chance of updating compatibleCoreVersion to accurately convey the module's compatibility so people know if they can safely install it on modern Foundry releases?

This applies to the other Game Audio Bundle's as well, but I won't spam tickets in each repo as they're basically just shards off this.