datafuselabs / databend-go Goto Github PK

currently we support Open with a DSN, however sometimes we wanna pass some hooks into the driver.

a Config struct might better on doing this job than a string DSN

db.QueryRow has GET" "10.49.2.4" "/v1/query/f29bec11-7128-4fde-abc7-013e965d5f54/final error when query through nginx.

	)panic: failed to scan result &sql.Row{err:(*fmt.wrapError)(0x1400009e4e0), rows:(*sql.Rows)(nil)}: newTextRows: failed to create a data parser for the type 'VariantObject': type VariantObject is not supported

on executing PRESIGN UPLOAD @~/test.csv

the result of PRESIGN contains one JSON field like:

i use ng for databend-query
go driver SDK is 0.4.8
i use db.Exec("INSERT INTO testd VALUES('111.111.111.111',?)",x) ,the ng return 2 logs , post and get was success, post url and get url go to same node.
but
my code like this:
scope, err := db.Begin()
batch, err := scope.Prepare(fmt.Sprintf("INSERT INTO %s VALUES", "testd"))
for i := 0; i < 10; i++ {
, err = batch.Exec(i,x)
}
scope.Commit()
the ng return logs post 200 , get 404 insert failed :
1703745676.977 "10.49.2.134" 422 "POST" "10.49.2.187" "/v1/query" "" "10.49.2.187" 8000 "/v1/query" "-" "HTTP/1.1" 1557 1239 200 0.008 "-" "databend-go/0.4.2" "-" "-" "-" "-" "10.49.2.57:8000" "-" [28/Dec/2023:06:41:16 +0000]
1703745676.983 "10.49.2.134" 323 "GET" "10.49.2.187" "/v1/query/685870bc-8e5a-4098-8715-793f70d08a10/final" "_" "10.49.2.187" 8000 "/v1/query/685870bc-8e5a-4098-8715-793f70d08a10/final" "-" "HTTP/1.1" 241 118 404 0.005 "-" "databend-go/0.4.2" "-" "-" "-" "-" "10.49.2.207:8000" "-" [28/Dec/2023:06:41:16 +0000]
databend-query log timeout 60s
the post url and get get url not go to same node. so is a bug?

related: https://github.com/databendcloud/bendsql/issues/90

package main

import (
	"database/sql"
	"fmt"

	_ "github.com/datafuselabs/databend-go"
)

func main() {
	db, err := sql.Open("databend", "http://databend:databend@localhost:8000")
	if err != nil {
		fmt.Println(err)
		return
	}
	scope, err := db.Begin()
	if err != nil {
		return
	}

	batch, err := scope.Prepare(fmt.Sprintf("INSERT INTO %s VALUES", "gottt"))

	for i := 0; i < 10; i++ {
		name := fmt.Sprintf("name%d", i)
		if i == 9 {
			name = ""
		}
		_, err = batch.Exec(i, name, i*2)
	}

	err = scope.Commit()
}

when id = 9, the name is NULL:

But the name should be "" (empty string).

Reason

When execute batch insert, the csv file generated is:

0,name0,0
1,name1,2
2,name2,4
3,name3,6
4,name4,8
5,name5,10
6,name6,12
7,name7,14
8,name8,16
9,,18

databend kernet will handle the empty string as NULL when copy into.

when the value has ‘ ， the return value is truncated

The PR: #78
add some test around session level role setting in golang driver, which behave as expected, while it did not change unset related issues but there are some unexpected thing occurs.

I think it is related to the PR
datafuselabs/databend#13062

Issue error
https://github.com/datafuselabs/databend-go/actions/runs/6765657226/job/18385601947?pr=78

Now the go driver use databend cloud API, we should support clickhouse http protocol.

you may get a ProvisionWarehouseTimeout on cloud resource exhausted. This error is safe to retry, because the query is not actually sent to the warehouse.

with this error get handled, the sdk could be more robust on access cloud warehouse from databend cloud.

currently databend-go print logs by defualt:

it can be better to print the logs only when the log option in DSN is enabled.

if compress is true then compress the file to upload.

Should make a test as the following steps:

1. set max_active_session=10
2. do insert, update, delete concurrently

Then there should not has exceed max session error.

The document showed a not working batch insert example

It should be like the code in test