dashfwd / kotlin-cache2k-spring Goto Github PK

The cache configuration looks strange:

        val expiryPolicy = { key:Any, value:Any?, loadTime:Long, oldEntry:Any? ->
            if (value == null) { ExpiryTimeValues.NO_CACHE } else { ExpiryTimeValues.ETERNAL }
        }
       ....
           expireAfterWrite(30, TimeUnit.SECONDS).permitNullValues(true).
           expiryPolicy(expiryPolicy)

Is there really any troubles with null values? Probably you can remove permitNullValues(true) and the expiry policy.

The example right now, reads all persons in one go and just all persons in one entry.
This kind of scenario is quite rare in real world. In case you have millions of persons, you would use a cache, so the persons you are currently working with are available faster.

So I would put one person per cache entry.

Suggestions:

• Establish a person ID
• have a cachable method to get a person: Person get(String id)
• hava a cachable (the search cache) method to find persons: List<String> findPersons(String searchString)