darthfubumvc / fubucore Goto Github PK

View Code? Open in Web Editor NEW

69.0 69.0 43.0 5.3 MB

License: Other

Ruby 0.04% C# 99.96%

fubucore's People

Contributors

Stargazers

Watchers

Forkers

ahjohannessen nieve jmarnold jcteague davidalpert mkmurray kevm staxmanade gbrunton pedroreys chadmyers cerilewis wmchristie emiaj schotime stgwilli spascoe mtscout6 rasupit rsanders1 dovetailsoftware hartez vyrak andyalm wbinford roend83 chester89 whiteboxsoftware ventaur-forks garylcoxjr jbogard alistair ryanhauert ryankelley pondidum modzel79 ewilde ssadevelteam nwendel cerebralmischief acrigney nvrnight semihkarduz

fubucore's Issues

Every single extension method on Type that does a boolean check needs to accept nulls

FubuMVC conventions might be easier to use if all the FubuCore TypeExtensions would just return false if it gets a null type.

Thinking of things like:

type.HasAttribute<>()
type.CanBeCastTo<>()

and so on.

Redo the recursion detection in model binding

Got lost when property stack was removed. Figure out a way to bring it back

Convenience method for Description.AddChild(name, object)

Just cleaner than doing:

description.Children[name] = Description.For(object)

HttpFileCollectionWrapper binding fails when uploading files

Using Nuget, we installed the Razor view engine (FubuMVC.Razor v0.9.5.817 and RazorEngine v3.0.8) which upgraded the following packages:

Bottles from 0.9.1.202 to 0.9.1.224
FubuCore from 0.9.4.117 to 0.9.8.130
FubuLocalization from 0.9.4.116 to 0.9.5.17
FubuMVC.References from 0.9.4.762 to 0.9.5.817

Now when we upload files the HttpFileCollectionWrapper value on our input model is null.

Downgrading all of the packages and grabbing the older Nuget FubuMVC.Razor -Version 0.9.4.768 fixed things.

Make ShouldHaveTheSameElementsAs spit out the actual values anytime an assertion fails

Add FileSystemExtensions for reliable cleaning

public static class FileSystemExtensions
{
    // Basic integration coverage on this but having to rely mostly on manual testing here
    public static void ForceClean(this IFileSystem system, string path)
    {
        if (path.IsEmpty()) return;
        if (!Directory.Exists(path)) return;

        try
        {
            cleanDirectory(path, false);
        }
        catch
        {
            // just retry it
            cleanDirectory(path, false);
        }
    }

    private static void cleanDirectory(string directory, bool remove = true)
    {
        string[] files = Directory.GetFiles(directory);
        string[] children = Directory.GetDirectories(directory);

        foreach (var file in files)
        {
            File.SetAttributes(file, FileAttributes.Normal);
            File.Delete(file);
        }

        Thread.Sleep(10);

        foreach (var child in children)
        {
            cleanDirectory(child);
        }

        if (remove)
        {
            Thread.Sleep(10);
            Directory.Delete(directory, false);
        }
    }
}

Improve TemplateParser handling of missing Keys

@mkmurray and I will get this tackled pretty soon and have a PR for making this friendlier.

Figure out approach to warning about or erroring on missing keys
Document SettingsProvider usage
Document escaping property variables (i.e. {somekey}) and how to escape using {{}}

Add a new convention for value/object conversion that can convert strings to a T if there's a new T(string) ctor

This would be really handy for value types and testing scenarios

Command Line Help and Arrays

If you have an enumerable argument as a 'argument' it shows up as a 'flag'

see bottles bundle

LogListenerCollection cannot ever throw exceptions

Use the new model binding diagnostics in SettingsProvider

Use the new RequestSource signature when creating the diagnostic report for settings data. Will eliminate new duplication in the code.

Go rework the DescriptionTextWriter

Added a bunch of new things to Description. Just more to do.

Add SystemTime.AtLocalTime( time of day )

It's silly, but it would make test setup a lot quicker in many cases

DependencyGraph usability

The DependencyGraph has poor usability. Do something to make it easier. I'm thinking a bit of an FI like FubuApplication.

Move TypePool to FubuCore & give it a new ForAllAssemblies() method

Over and over again we keep using a model where we need to search through assemblies in the application by looking for the actual DLL/EXE files. Centralize this, and get TypePool to FubuCore.

Don't do until 2.0 though.

FubuException

Still hardcoding "FubuMVC" in message and the namespace is still in FubuMVC.Core - looks like a bad refactoring. Or is this namespace still there to prevent compilation errors in someone's app?

Add first class support for stubbing out ILogger w/ RecordingLogger in the InteractionContext

I wants it.

AggregateDictionary needs to be able to produce a report of what it has

Something almost exactly like what we do for diagnostics for the SettingsData. Gonna want it to explain what happens in model binding.

Add the Url extensions from FubuDocs for url manipulation

public static class StringExtensions
{
     public static string AppendUrl(this string url, string part)
     {
         var composite = (url ?? string.Empty).TrimEnd('/') + "/" + part.TrimStart('/');

         return composite.TrimEnd('/');
     }

    public static string ChildUrl(this string url)
    {
        return url.Split('/').Skip(1).Join("/");
    }

    public static string ParentUrl(this string url)
    {
        url = url.Trim('/');
        return url.Contains("/") ? url.Split('/').Reverse().Skip(1).Reverse().Join("/") : string.Empty;
    }
}

Need deep object graph tests with SettingsRequestData

Pretty sure this isn't accommodating deep object graphs because of the period naming thing. Need acceptance tests on it that hit both deep graphs and enumerables

CompositeFilter<T> gives false negatives when there are no Excludes

Import "Platform" from Bottles

per Alistair's suggestion

Boolean converter needs to respect "N" or "n"

Add a new ConsoleListener

// TODO -- this should be in FubuCore.  Nice to make a switch for it.
// Maybe use FubuMode?
public class ConsoleListener : ILogListener
{
    public bool ListensFor(Type type)
    {
        return true;
    }

    public void DebugMessage(object message)
    {
    }

    public void InfoMessage(object message)
    {
        Console.WriteLine(message);
    }

    public void Debug(string message)
    {
    }

    public void Info(string message)
    {
        Console.WriteLine(message);
    }

    public void Error(string message, Exception ex)
    {
        Console.WriteLine(message);
        Console.WriteLine(ex);
    }

    public void Error(object correlationId, string message, Exception ex)
    {
        Console.WriteLine(correlationId);
        Error(message, ex);
    }

    public bool IsDebugEnabled { get { return false; } }
    public bool IsInfoEnabled { get { return true; } }
}

Make FileSet less annoying to work with

Dunno yet. More ctor's? Maybe some static builders?

Upgrade FubuTestingSupport to the latest SM release

Causes havoc w/ NuGet right now

Redo how BindingResult errors are tracked

Tracking by accessor or PropertyInfo by itself is just going to be too hard. Need a new class to track them and retrieve/query binding errors. Will spill into FubuMVC.Validation too.

FubuLocalization headers, would be nice to tie multiple Types together

Kind of annoying. When we do projections from something like "Source" to "Dto", the property names may be exactly the same, but the underlying type is the same. Like to have a way that FubuLocalization can just forward properties on. We had this at Dovetail way back when

Command line help for array arguments does not look right

Use bottles ? deploy to reproduce

Upgrade NUnit in FubuTestingSupport

In localization, the missing key handler needs to be bouncing throw ToLocalizationKey()

Today it's just looking at StringToken.Key. That was hunky-dory before we introduced the new, silent namespace by type, but doesn't fly now.

Get some end to end tests on Localization

Focus on the basic localization. Hit property headers vis a vis the missing header

SettingsData should use an IValueSource internally

Makes Josh's work w/ Object Blocks easier

Convert the build to FubuRake & kill off buildsupport

PathRelativeTo isn't handling parallel directories well

Putting an extra ".." in.

folder1/file1
folder2/file2

path relative to is getting "....\folder1\file1" instead of "..\folder1\file2"

Anything depending on DictionaryValueSource needs to be able to read enumerables

Need to do some Regex work to get at "Property[0]". Joy.

Merge the ObjectConverter model with ValueConverter from model binding

This is causing people issues because of the double duty

Build a test harness of some sort for custom model binding pieces

Unit testing a PropertyBinder or a ValueConverter in an integrated fashion is tedious. Do something like the PersistenceSpecification in FNH maybe.

be able to set services
request data
hide the setup of IBindingContext

Tighten up the locking in the Cache class

Need to be more aggressive with reader/writer locks in the Cache class. Of course, the last time someone tried to make a fancier locking Cache that damn thing just didn't work. However, I'm an optimist

Command Line Alias short form should be CASE SenSitiVe

Alias attribute overrides field name

The alias flag overrides the name of a property, but this feels counter-intuitive. An alias would provide an optional name for a property instead of overriding it. This would be useful when one wants to make "short" and "long" command line flags.

For example

[FlagAlias("z")]
public String ZipFile {get; set;}

Feels like it would allow for this usage

fubu new -zipFile ../../MyZipfile.zip

fubu new -z ../../MyZipfile.zip

but at the moment you only get the shorter -z version instead of both options.

Add the FileEscape extension method from ripple

Too useful to not be here.

Help text for IEnumerable flags isn't showing up

Build a command with:

public IEnumerable OptionsFlag {get;set;}

and do "exe ? command", you don't see the OptionsFlag listed

PassthroughConverter needs to be BindingValue aware

tracking issue for resolving FubuMVC issue #286. Fubu can't bind the ASP.NET files collection because the PassthroughConverter is returning a BindingValue which the ConversionPropertyBinder is trying to set directly on the input model "Files" property and an exception occurs.

PassthroughConverter needs to be BindingValue-aware and get the raw value out of the BindingValue if necessary.

See this discussion on the fubu mailing list

fubucore does not build because it depends on FubuDocs 0.0.0.10 which is not available from Nuget

Add Enumerable binding to SettingsRequestData

It's a NotImplementedException at the moment. Will need a pretty wide spread of tests on this too

FubuException

Still hardcoding "FubuMVC" in message and the namespace is still in FubuMVC.Core - looks like a bad refactoring. Or is this namespace still there to prevent compilation errors in someone's app?

Two classes named the same

FubuCore.Binding.StatelessConverter
FubuCore.Conversion.StatelessConverter

Both of these classes are named the same. I would suggest renaming FubuCore.Binding.StatelessConverter -> FubuCore.Binding.StatelessBindingConverter.

That said, JDM has pointed out that it would be cheaper (lower impact on others) to instead change 'FubuCore.Conversion.StatelessConverter' but I don't have a name suggestion for it.

Add public FieldInfo's to the model binding support

Today model binding only supports properties, but what about adding public fields as well? It would cut down on some code noise, especially for the Settings objects.

FileSystem.FindFiles doesn't respect Excludes

If you pass a FileSet object with Excludes set, the exclusions are ignored.