dart-league / ng2_strap Goto Github PK

I would suggest implementing a n2s-navbar component.

Thanks so much for your package. It is a great work, even though it is still not complete.

When I try to use the alert with the close button it is looking for a png inside my assets lib and its gets a 404

Not Found: http://localhost:63342/fc-app/web/packages/fc_app/assets/img/icons/noti-cross.png

But I also can seem to find the pngs anywhere in the lib or bootstrap?

there are some files named using TS dash-case. They should be renamed to use snake_case instead

right, top, and bottom seem to work correctly

Readme instructions tell that step 2 (adding sass dependency) is optional, but when I tried without sass dependency I could not move futher.
I believe for end-user of the ng2_strap dependency from sass will be unfortunate complication.
I think it's more OK to use one or another css transformer in application but for end-users of library some option to consume library with minimal dependency chain would be much more preferably.

Specifically for me that just did not work. I installed ruby and sass on Windows10 (Russian). But sass transformer broke with unreadable messages (messages were unreadable due to some sort of character map conversion errors in CLI). After some trials I've temporarily changed some language settings to US-EN in Windows (that by necessity broke other programs) to get gist of these messages. And after rebooting sass transformer started to work. Then I'll get some weird behaviour in WebStorm -- namely never ending skanning of the files to build the index. Probably unrelated to sass, but that project worked before and I was running out of time so I've switched back.

I've noticed too that sass package depend from old unittest and some other old stuff. I guess it could be a problem for a pub version solver in future.