darrenatherton49 / upnext Goto Github PK

Always test the release APK, especially for missing ProGuard rules etc.

Update the iconography in the app, for example:

• Add to watchlist
• Add to list
• Watched button
• Bottom navigation icons

On the content detail screen, a movie or TV show has a list of genre chips. These chips should be clickable. When clicked, the user should be shown movies or TV shows for that genre (as a discover filter/tab).

Add setting to navigate to show or movie watch list after adding it on the detail screen.

• Logo
• App name
• Add 'View/rate the app on Google play' button
• Add social links
• TMDB attribution
• Link to UserReport to suggest improvements

• [] Add a shortcut to add to watchlist on grid screens such as a long-press or double-tap.
• [] Add a setting to toggle either 'no gesture', 'long-press' or 'double-tap'.

One the tv show detail screen, show only the first runtime by default.

Add setting to show all runtimes for episodes instead of just one.

• [] Setting to toggle between one and multiple runtimes
• [] Update content detail screen mapper to generate runtimes based on setting

Use the release checklist to make sure everything is done:
https://developer.android.com/distribute/best-practices/launch/launch-checklist

When the user clicks the view mode toggle from grid -> list, the app should show a list of movies or TV shows instead of a grid.

Implement the list mode XML layout.

Implement a screen similar to YouTube where you can create a new list. If this screen is navigated to from the 'add to list' dialog, automatically add the movie/tv show passed in after the new list has been created.

• Save new movie list to database
• Save new tv show list to database
• If movie or tv show is passed in as part of adding to list, add the content to the list in the database.
• When complete, close the dialog and show some feedback to user (e.g. SnackBar saying 'list created' with a 'view list' button).

Decide when to invalidate/delete some of the past searches. E.g. only keep the 50 most recent searches and search results.

• [] RoomSearchTerm
• [] RoomSearchResult

• [] Update the grid/list pages to show an icon to show which content you have already watched without clicking into the detail screen
• [] Add a setting to toggle (show/hide) the above icon

Abstract the Dao's and Retrofit services behind a 'DataSource' interface for testing.

Go through the play store listing and optimise everything.

• Make sure to say things like 'this app does not allow you to watch movies or tv shows'
• Give TMDB attribution etc.
• Make sure there is no copyrighted content in the listing

Go through every screen and make sure they are consistent with each other - there should be some sort of 'design language' feel to the app.

For each screen that can have errors, change error layout so that whole screen is clickable to retry instead of just a button.

Have option to sort the list items, e.g. in the movie watch list

• Recently watched
• Alphabetical

Pre-load and cache the data needed for discover to work instantly (use WorkManager to periodically fetch data and also fetch it on first app run).

Show fallback data and offline message (as a SnackBar) if the network requests fail but we still have database data for each screen.

Fetch and store a new config every 3 days (call the ConfigRepository refreshConfig() function) as per TMDB documentation.

Check for Google play policy compliance - read the guidelines on compliance and the different rules, especially on copyright etc.

Implement advanced search/filters. E.g. by genre (using Discover API). Advanced search can be found on the 'Discover' screen.

• Ensure that we have set up the menu xml for each screen
• Ensure that we have implemented each option inside fun onMenuItemClicked(menuItem: MenuItem): Boolean in each Fragment.

• When an episode is marked as 'watched', update the season 'watchCount'.
• When an episode is marked as 'watched', update the episode 'watched' flag
• Add each episode to the history list when it has been marked as watched.
• Add show to 'watched' list and update its' Boolean fields when every episode has been watched.
• The 'up next'/'watchlist' screen should have a button so that it is 'one click' to mark the next episode as 'watched'. So you should see the episode you're currently on, be able to click 'watched' and the next episode should come up. Also add 'undo' snackbar for this action for accidental clicks.

Add ability to follow a person as well as a tv show and movie so you can go through and watch someone's filmography.

Implement person detail screen - use a RecyclerView similar to the content detail screen so that we can customise and re-order sections.

Figure out when to invalidate data, e.g. stored movies, tv shows and people.

• When to refresh the data (e.g. when someone goes to the movie detail screen, the getMovie() call should go to the network instead of the database if X time has passed or something)
• When to delete the data (e.g. old searches)

• Add each movie to the 'watched' list
• Update its' Boolean fields when it has been marked as watched.

Ensure that all XML layouts are shallow and fast - use ConstraintLayout where needed.

Add privacy policy:

• In app
• On play store

Have a look at the different ViewMapper files and see if they can be sorted or split out into better-related functionality.

Go through all TextViews and Buttons and ensure that:

• Font is consistent throughout all text
• TextAppearances are consistent - e.g. all titles have appearance X and all subtitles have appearance Y.
• Capitalisation is correct and consistent throughout app.

Implement remaining sections on detail screen such as 'seasons' in the buildContentDetailSections function.

• 'Add to list' UI on movies screen
• 'Add to list' UI on movie detail screen
• When fetching lists, we need to find the 'checked' status for that specific movie. Probably need to look at the RoomMovieListJoin entity when constructing list items. If the movie exists in that table for a given list id, then the item isChecked should be true. Return a list of ContentListStatus containing the list data and the isChecked status.
• Update database to create link between movie and list.

ViewMapper files (e.g. data -> domain) have many functions in now. We need to either find a way to split them into separate files or organise the functions by functionality.

Have option to sort the list items, e.g.

• Recently watched
• Newest episode
• Alphabetical
• Total episodes
• Episodes left to watch

When user navigates to the content detail screen, we should show whether or not the movie or TV show has been watched.

The discover screen shows data in tabs from different data sources such as 'Now Playing' and 'Popular'. Figure out which tabs are best to show and in what order.

When each screen rotates, it should:

• Restore UI state
• Have a good-looking horizontal layout

• Turn on ProGuard/R8 and configure rules for all libraries
• Go through our Gradle dependencies and implement ProGuard configurations (such as keeping certain classes) for all libraries. Running ProGuard without this configuration usually breaks classes used e.g. in Dagger 2 or Retrofit, so we should check how to configure it for all dependencies as well as our own code.
• Enable R8 and compare APK size before and after minify
• Add deobfuscation files to developer console for bug reporting

Implement Shows Screen

• Watchlist
• Watch history/Watched

This should be displayed as tabs in ShowsFragment.

Add genres tab to the discover screen tabs to easily look at genre (as well as in the advanced filter).

Cut down all data models I don't use to decrease memory footprint.

For example on the list/grid screens, we probably don't need a lot of the attributes other than the name and the image urls for the content. Then when we navigate to the detail screen, we get everything.

• [] API models - comment out any fields we don't need to parse
• [] Room models - comment out any fields we don't need to save
• [] Domain models - comment out any fields we don't need to convert from API to domain
• [] View models - instead of holding entire object (e.g. Movie), express the UI state only as fields we need (e.g. 'name', 'imageUrl' etc.)

Ensure that all ViewHolders use 'LayoutContainer' from kotlin android extensions on ViewHolders for view caching.

Every screen should have consistent loading and error visuals.

• Ensure that errors and 'retry' layouts look the same on all screens.
• Ensure that all loading spinners are central to the screen.

We need to create a launcher icon (an adaptive icon).

https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive
https://proandroiddev.com/android-adaptive-icons-are-easier-than-you-think-3c66be2dd4dd

Look at the pre-launch report and fix any issues in there.