darren80 / jammming Goto Github PK

I liked the consistency of your code structure which made it very legible and easily understandable. I would only recommend that when a tag has multiple attributes associated to it, it's better off having each of them on their own line.

https://github.com/Darren80/Jammming/blob/master/jammming/src/Components/TrackList/TrackList.js#L13-L15

Although it doesn't necessarily hurt the functionality of your project, there were quite a bit of console messages that should be dealt with. We generally want to avoid these in a "production" setting.

Or here's a given message to help:
"To ignore, add // eslint-disable-next-line to the line before."

I REALLY love the addition of comments in your project.
As someone that reads other people's code, it's incredibly helpful to have an inside peek at the thought process and explanation of your code without having to decipher it myself. It also helps with logic and debugging when unforeseen circumstances occur.
Great job with this, please do continue to leave more comments as I'm sure it'll be both beneficial for you and those you work with!

Amazing project with a nice personal touch of the "play" button!

• Your code was written and structured well which made it legible and easy to navigate. The addition of comments was helpful and my only "complain" is that I wish you added more!
• Small improvement of putting attributes on their own line can be taken.
• Console messages should be dealt with by trying to minimize the number of their appearances.

Overall your project was a great success! It was well written and it shows through the flawless functionality of your project. Keep up the good work!

Grade: Meets expectation!

I haven't seen many deviations from the design spec but your addition of the green "play" button was really cool! Great job on that.
The only issue I have with this is that it appears on some songs and not others. This inconsistency kind of throws me off.