darksworm / imgsel-x11 Goto Github PK

Currenlty i have it set in my i3 config that the window should be floating. This should be inferrable.

Currently we load the file list only once. We should be able to handle missing files.

Goal: when a file gets deleted or moved, the app doesn't crash when trying to load/draw it.

If its not too cumbersome, maybe we can handle renamed files too.

as of darksworm/emojigun@75e9292 we correctly handle multiple screens when running on xinerama, we should also handle this without xinerama.

A lot of the headers include their implementation code files (.cpp).

This is a terrible practice, .cpp files should not be included

• target image size
• max image size
• Rows, columns
• Image resize mode (scale, crop, etc.) (scale by default to max image size)
• initial input mode
• image filenames should be passed as a list (bash glob) instead of as a glob string
• image cache size

To purge the cache, keep only n (defined in CLI params) images in memory at a time. When we load the n+1th image, remove oldest image.

• Center titles
• set title max length

nice-to-have:

• fancier selection box?
• marquee on selected item title (if its too long to fit)
• a font that doesn't suck

When in navigation mode; moving causes crashes because the indexes are fucked.

type: UP, canmove: 1 oldIdx: -1620727809 newIdx: -1620727813 

This requires some thought.

Do we take the image size as a parameter and then resize everything to fit?

Do we try to make a fancy collage like thing? This would hurt navigation

I thinks this has to do with the window itself being transparent.

It should only take up one screen. I thought i fixed this.

XRANDR --verbose output

The image bounding rect size should not be hard-coded.

Make it as CLI params?

Automatic? (Image size + some padding?)

1. Search by text
2. Clear search
3. Enable vim mode
4. press shift+g
5. app crashes

I keep making stupid mistakes... A nazi is required to enforce some rules.

Ex.: missing return statements in methods with a return type.

As I'm raw as fuck in C++, I've probably ignored best memory management practices & have created some memory leaks in the code as well.

• Make sure everything that needs to be freed is freed (smart pointers?, delete?)
• Special: check that all XLib & other external library items are freed (XFree, etc)
• Do memory leak testing, patch holes

We should probably have the keyboard listener on a different thread than the renderer.

We're probably not handling some x event.

a red rectangle perhaps.

Should investigate whats missing/broken in vim mode & patch things up.

When rendering image on a pixmap & then copying it over to the window introduces artifacts.

there is too much happening in main.cpp, some refactoring is required.

Having a fixed amount of bubbles is confusing, so lets just not show anything.

I can probably show which page you're currently on, but not how many pages there are in filter mode.

Don't reload images on every new frame, instead keep them cached until their page is destroyed

Could we keep the emojis on off-screen pixmaps and just copy them over when required?