dariopellegrini / formbuilder

An Android library to build form and form validations easily.

🛠 - Featured Repositories

🍎 - iOS

🤖 - Android

🖥 - Backend

Projects

Italy Nowadays

iOS & Android
News from the world, updated, fast, safe

Stormy Europe

iOS
Stay informed about severe weather events in Europe

Odeum

iOS
Generate your podcasts with AI

formbuilder's Issues

implement custom style for FormElement?

how to implement custom style in form element? its might be really useful to had 👍

Spinner in forms

This is an excellent library, but spinners are necessary, when you think we could enjoy this feature, thanks

Errors do not appear for some FormElement types

If the FormElement type is set to any of the following, then the error message does not show if validation fails:

• SELECTION
• MULTIPLE_SELECTION
• DATE
• TIME

I believe this is because the FormBuilder.buildElement() method adds the wrong EditText object to the viewMap:

                textInputLayout = new TextInputLayout(context);
                final EditText selectionEditText = new EditText(context);
                ....
                // Wrong object added here!
                viewMap.put(formElement.getTagOrToString(), editText);
                addViewToView(textInputLayout, selectionEditText);

The selectionEditText object is added to the screen, but the editText object is added to the map. So when FormBuilder.validate() is called then the error is added to editText instead of selectionEditText.

Problems with Single Selection

When using single selection mode, if you try to change the value by clicking on the edittext it simply adds the new selection to the EditText making it act like Multiple Selection

We can fix it by replacing the pickDialog() Method with the following

   private void pickDialog(final EditText selectedEditText, final FormElement selectedFormElement) {
        this.selectedEditText = selectedEditText;
        AlertDialog.Builder builder = new AlertDialog.Builder(context);
        builder.setTitle("");
        builder.setSingleChoiceItems(selectedFormElement.getOptions().toArray(new CharSequence[selectedFormElement.getOptions().size()]), selectedFormElement.getCheckedValue(),     null);
        builder.setPositiveButton("OK", new DialogInterface.OnClickListener() {
            @Override
            public void onClick(DialogInterface dialogInterface, int i) {
                dialogInterface.dismiss();
                int selectedPosition = ((AlertDialog) DialogInterface).getListView().getCheckedItemPosition();
                String selectedElement = (selectedFormElement.getOptions().get(selectedPosition));
                selectedFormElement.setValue(selectedElement);
                selectedEditText.setText(selectedElement);
            }
        });

        builder.setNegativeButton("Cancel", new DialogInterface.OnClickListener() {
            @Override
            public void onClick(DialogInterface dialogInterface, int i) {
                dialogInterface.dismiss();
            }
        });
        builder.show();
    }

Use in Fragments and tabs

Good afternoon.
There is some example of this excellent library to use it with fragments and tabs. thank you

Required validation of SELECTION and MULTIPLE_SELECTION fails

If you set a FormElement of type SELECTION or MULTIPLE_SELECTION as required, it will always fail validation because FormBuilder.validate() checks the value field on the FormElement but not the optionsSelected field that is set for these types.

if (element.getRequired()) {
    // Should check optionsSelected if element.type == SELECTION or MULTIPLE_SELECTION
    if (element.getValue() == null || element.getValue().length() == 0) {
        isValid = false;
        if (view instanceof EditText) {
            ((EditText) view).setError(element.getErrorMessageOrDefault());
        }
    }
}