dariomrk / evalexpression Goto Github PK

Issue type

Chores

Describe the solution you'd like

• Update .sln in project root to reflect renaming changes
• Update repository name
• Update README title

Additional context

No response

Related component

Parser

Describe the solution you'd like

Given the -2(3+1) expression, the parser should correctly output an AST like this:

BinaryNode Multiply
|
|__ UnaryNode Negative
|    |
|    |__ NumericLiteral 2
|
|__ BinaryNode Add
     |
     |__ NumericLiteral 3
     |__ NumericLiteral 1

Additional context

No response

Affected component

Parser

Bug description

The UnaryNode of type Negative does not get evaluated correctly.

Related unit test case:

[Fact]
public void ImplicitNegativeNumber()
{
    // expression: -2
    var input = new List<Token>
    {
        new Token(TokenType.Hyphen, "-"),
        new Token(TokenType.Number, "2"),
        new Token(TokenType.EndOfFile, null),
    }.AsEnumerable();

    var expected = new UnaryNode(
        NodeType.Negative,
        new NumericLiteralNode(2));

    var parser = new Parser.Parser(input);
    var actual = parser.Parse();

    Assert.Equal(expected, actual);
}

Steps to reproduce

No response

Expected result

The UnaryNode of type Negative should always correctly precede:

• parenthesized expressions
• any other operator, regardless of that operator's precedence.

Relevant log output

No response

Issue type

Documentation

Describe the solution you'd like

• Update README

  • Add more samples
  • Cleanup features section

• Add documentation comments to the codebase

  • At minimum add doc comments to public APIs

Additional context

No response