dario-loi / staplegl

No-dependency OpenGL support library, which abstracts OpenGL objects

Hi 👋, I'm Dario Loi

A Computer Science & AI student from Rome, Italy

• 🔭 I’m currently working on StapleGL

• 🌱 I’m currently learning Robotics

• 👨‍💻 All of my projects are available at My Portfolio

• 📝 I sometimemes write stuff on My Blog!

• 💬 Ask me about C++, Computer Graphics

• 📫 How to reach me [email protected]

Connect with me:

Languages and Tools:

 

staplegl's Issues

[BUG] Function definitions inside headers are not `inline`.

Describe the bug
Definitions of member functions inside headers should be marked inline. They're only implicitly inline if they are contained within the class definition body, are templates (not full specializations), or marked constexpr. Applies to member functions of vertex buffer wrappers, framebuffer wrappers, etc. Haven't looked at all the code, but it's probably consistently missing.

To Reproduce
Steps to reproduce the behavior:

1. Create 2 .cpp files;
2. Include any header in both;
3. Compile and link;
4. See ODR violation.

Expected behavior
*Happy linker noises*

Desktop (please complete the following information):

• Haven't actually tried this on a machine, but it's an ODR-violation even when I just think about it.

Additional context
Clang-tidy is heavily recommended. Catches this immediately.