daot / bcdl

🎧 Gets free to download albums from Bandcamp

bcdl's Issues

Free track falsely recognized as paid since it's not downloadable from the album page directly

Sample links :
https://uneviepourrienvinyles.bandcamp.com/album/the-old-firm-casuals-the-headliners-split-ep
the actual dl link is https://uneviepourrienvinyles.bandcamp.com/track/the-headliners-cmon-cmon?action=download

https://uneviepourrienvinyles.bandcamp.com/album/8-6-crew-old-reggae-friends-lp-ep
https://uneviepourrienvinyles.bandcamp.com/track/where-have-all-the-bootboys-gone?action=download

https://uneviepourrienvinyles.bandcamp.com/album/8-6-crew-old-reggae-friends-lp-ep
https://uneviepourrienvinyles.bandcamp.com/track/old-reggae-friends?action=download

etc

Error "undefined: soup.Post" when compiling

After taking care of dependencies on Manjaro I'm getting this error when compiling:

# command-line-arguments
./bcdl.go:38:21: undefined: soup.Post
./bcdl.go:366:2: undefined: soup.PostForm
./bcdl.go:458:109: releasePageHTML.HTML undefined (type soup.Root has no field or method HTML)
./bcdl.go:542:137: releasePageHTML.HTML undefined (type soup.Root has no field or method HTML)
./bcdl.go:584:21: undefined: soup.Post

Any idea why this would happen?

Artists with dash in URL not downloading

(sax music starts)

My name is Jones. Detective Jones. I hunt bugs for a living.

First off, excellent piece of software, love that I can grab descriptions and reviews for every album. Sadly, I'm unable to download albums from artists with dashes in their ID. Afraid we've got a bug on our hands.

I went to grab albums from this page here:
https://dream-catalogue.bandcamp.com/music
I thought everything was going well until I noticed that bcdl had cut off the first part of the URL without the dash, and was downloading from catalogue.bandcamp.com instead:

==> https://dream-catalogue.bandcamp.com/music
>>> Getting links from Artist Page (May take a while)

==> https://catalogue.bandcamp.com/album/high-grey-effective
### Paid

==> https://catalogue.bandcamp.com/album/6-tracks-demo
--- 6 tracks demo by Catalogue
>>> fsig=70ae2e80338d0058c8c041867a88f928 id=853020959 ts=1626092884.0
==> https://popplers5.bandcamp.com/download/album?enc=flac&fsig=89761aeba0ebdd16ed80f38094bdbe5b&id=853020959&ts=1626092884.4146229350
 134.08 MiB / 230.54 MiB [======================================>---------------------------]  58.16% 2.23 MiB/s 00m43s

I tried putting the link in quotes but nothing changed so I decided to try a single album from the page in a text file with the -b option. Despite being free, bcdl reported it being paid and refused to download it:

==> https://dream-catalogue.bandcamp.com/album/flightwave-passions-vol-2
### Paid

To make sure this wasn't an issue unique to this specific page I quickly found another random artist page with a dash:
https://isistheband-ipecac.bandcamp.com/music
This time, likely because ipecac.bandcamp.com doesn't have any releases, bcdl output this:

==> https://isistheband-ipecac.bandcamp.com/music
>>> Getting links from Artist Page (May take a while)

panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x8 pc=0x71b0fa]

goroutine 1 [running]:
github.com/deepsheth/soup.findAllofem.func1(0x0, 0xc000033160, 0x1, 0x1, 0x868100)
        C:/Users/toad/go/src/github.com/deepsheth/soup/soup.go:529 +0x41a
github.com/deepsheth/soup.findAllofem(0x0, 0xc000033160, 0x1, 0x1, 0x820700, 0xc000168486, 0x0, 0x8)
        C:/Users/toad/go/src/github.com/deepsheth/soup/soup.go:533 +0xf7
github.com/deepsheth/soup.Root.FindAll(0x0, 0x0, 0x0, 0x952b00, 0xc0000049c0, 0xc000033160, 0x1, 0x1, 0x0, 0x0, ...)
        C:/Users/toad/go/src/github.com/deepsheth/soup/soup.go:278 +0x73
main.artistPageLinkGen(0xc000168480, 0x1b)
        D:/Web/Programming/c/bcdl.go:553 +0x35d
main.availAndDownload(0xc000168480, 0x21)
        D:/Web/Programming/c/bcdl.go:701 +0x231
main.get(0xc00000c270, 0x2d)
        D:/Web/Programming/c/bcdl.go:733 +0x296
main.main()
        D:/Web/Programming/c/bcdl.go:865 +0xfe0 

Until this bug is fixed I'm afraid this case is still open.

(sax music finale)

Server-side code for generating mail addresses?

Any chance you could publish it so we don't have to relay on your own? as i assume getnada.com is your own domain name

panic: runtime error: invalid memory address or nil pointer dereference

⋊> ~/appz/bcdl on master ◦ go run bcdl.go https://cameleonrecords.bandcamp.com/music/                                                                                                                                                  01:58:03

     __                        __  __
    /  |                      /  |/  |
    ## |____    _______   ____## |## |
    ##      \  /       | /    ## |## |
    #######  |/#######/ /####### |## |
    ## |  ## |## |      ## |  ## |## |
    ## |__## |## \_____ ## \__## |## |
    ##    ##/ ##       |##    ## |## |
    #######/   #######/  #######/ ##/

==> https://cameleonrecords.bandcamp.com/music/
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x7ac712]

goroutine 1 [running]:
github.com/anaskhan96/soup.Root.Attrs(...)
	/home/me/go/pkg/mod/github.com/anaskhan96/[email protected]/soup.go:401
main.validateLink({0x7ffc52e235b3?, 0xc000014020?})
	/home/me/appz/bcdl/bcdl.go:646 +0x1d2
main.get({0x7ffc52e235b3, 0x2b})
	/home/me/appz/bcdl/bcdl.go:658 +0xcb
main.main()
	/home/me/appz/bcdl/bcdl.go:795 +0x142c
exit status 2

Got this error while trying to dl https://cameleonrecords.bandcamp.com/

[Feature Request] Download mp3s as a fallback

Please consider adding a possibility to download mp3 tracks of paid albums.

bdcl not working

When I open bcdl, it opens up a command prompt with the letters "bcdl" on it, but then it closes itself. I thought I had to fill up the config.yaml file but even after doing that it still closes on it own.

bcdl incompatible with custom domains

Some artists use custom domains for their bandcamp page but bcdl is not able to handle them. (example)

"Unable to get all tracks using this method"

I don't know why it's happening considering it was working for me just a bit ago (last time I tested it was about a month ago) but now the program shows "### Unable to get all tracks using this method" and hangs on ">>> WAITING".

It does start downloading after a while but I just wanted to let you know this happens

about falgs

it works completely fine but i can't change the quality it always downloads with the flac quality here are the command i tried:
bcdl.exe --quality="mp3-320" link
bcdl.exe --quality mp3-320 link
bcdl.exe -q mp3-320 link

doesn't work

after installing (and filling out the config) nothing works. opening the exe it shows a command prompt window for a spit second and nothing afterwards