Coder Social home page Coder Social logo

Python type annotation missing about neogen HOT 4 CLOSED

Nachtalb avatar Nachtalb commented on June 4, 2024 2
Python type annotation missing

from neogen.

Comments (4)

Nachtalb avatar Nachtalb commented on June 4, 2024 1

@Forthoney
Nothing, that's the point.

The first one is the one shipped by Neogen. The second one is the one I modified myself in the source file of Neogen. IMHO, it should set the types but default (but it doesn't as seen in the first instance). Maybe it can already do that somehow, and I have something wrongly configured, which is the question here.

from neogen.

Forthoney avatar Forthoney commented on June 4, 2024 1

Thanks for clarifying. I agree with you that the second case should be the default behavior

from neogen.

Forthoney avatar Forthoney commented on June 4, 2024

Not a contributor, but what's wrong with the second instance?

from neogen.

danymat avatar danymat commented on June 4, 2024

Hello, sorry for the delay, life is speedy at the moment :)
I'm following the following source for implementing google docstrings: https://google.github.io/styleguide/pyguide.html

And I didn't find any place where they specify the type. You can use numpydoc for python that normally uses types in their annotation convention, or update your neogen config to use your custom annotation convention.
If you find the place in google docstrings where they specify that a parameter should receive a type, I will make the change !

If you are not satisfied with the answer, do not hesitate to reopen the issue :)
Have a good day 🎈

from neogen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.