Coder Social home page Coder Social logo

Comments (4)

biojerm avatar biojerm commented on June 5, 2024 1

Yeah it is a great plug in. I looked at how the mapping works a bit more this morning and started to wrap my head around what is happening. My lua is a 1/10. So the difficulty is not coming from your code 😄 .

from neogen.

danymat avatar danymat commented on June 5, 2024

Scenario 1:

Results: args are there, but the Args: header is missing. I would expect it based on the template definition. Not the end of the world, just noticed it was different

Indeed, it's a bug. I will fix it.

Scenario 2

Results: Args in wrong order, and missing type of optional argument.

This is actual behavior:

  • Args in wrong order: the order can sometimes not be respected if the type of parameter is not the same (mixing optional and required params). I gave some ideas on how to fix this, but will require some deep thinking that i can't allow to myself on the upcoming days. I will take a look as a next enhancement.
  • Missing type: indeed, this functionality of getting types via default values is not developed. I will add to the list, if you think that could be a great thing.

Scenario 3

Results: typed optional argument completely missing.

It's a bug, thanks for catching it!

Thank you for this great feedback, and I hope you still find value in this plugin while those features are still in the queue.

from neogen.

danymat avatar danymat commented on June 5, 2024

Nevertheless, I don't think neogen could be complicated, but indeed it's complex.

A very good documentation alongside the actual code (even more because you're starting lua) is to check the help file:

:h neogen

Here, you'll get the philosophy, the idea behind code structure and how to understand/customize it

from neogen.

danymat avatar danymat commented on June 5, 2024

Hello, sorry for the delay (and merry Christmas)

I created a PR to fix bug 1 and 3 that you provided.
Can you try and tell me if everything works fine ?
Best regards

from neogen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.