danstiner / glimdroid Goto Github PK

Repro steps:

• Open a stream
• Hit back
• Close PiP window with the little "x" on it
• Open the same stream again

Expected result: Stream starts as normal

Actual result: Stream does not start, video is just black and the layout is messed up

Workaround: Open a different stream and then switch back to the one you wanted

Was watching a stream and had to go to browser base because glimdroid was disconnecting me from the stream every 10-20 minutes or more

This is somewhat expected, I haven't implemented anything to reconnect the websocket when it dies.

Doing so is a little tricky, any open subscriptions need to be opened again and any in-progress requests retried. It may be simpler to tie websockets to specific activities and then restart the activity when something goes wrong.

Similar story for Janus sessions, if they die we need to restart them.

Crash stacktrace:

kotlin.NotImplementedError:
at com.danielstiner.phoenix.channels.Socket$Listener.onFailure (Socket.java)
at okhttp3.internal.ws.RealWebSocket.failWebSocket (RealWebSocket.java:31)
at okhttp3.internal.ws.RealWebSocket$WriterTask.runOnce (RealWebSocket.java:15)
at okhttp3.internal.concurrent.TaskRunner.runTask (TaskRunner.java)
at okhttp3.internal.concurrent.TaskRunner.access$runTask (TaskRunner.java)
at okhttp3.internal.concurrent.TaskRunner$runnable$1.run (TaskRunner.java)
at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:641)
at java.lang.Thread.run (Thread.java:920)

Follow buttons would be nice, but will require new mutations in the Glimesh.tv API: Glimesh/glimesh.tv#718

When watching a stream, the Glimesh.tv server is told via the startWatching mutation that it should count the current user as a viewer on the channel. However there is no way to stop watching except to close the websocket, and I'd prefer to keep one socket open for the entire app if possible.

I think instead watching should be tracked as a graphql subscription so it can be stopped. Alternatively I'd have to switch to having multiple sockets open, one for getting general info / channel lists, then another opened per stream and closed when the stream switches. That's possible but adds noticeable latency and some complexity.

Users can accidentally navigate back to the sign-in page even after they've already completed sign-in