Coder Social home page Coder Social logo

Comments (6)

DannyBen avatar DannyBen commented on June 19, 2024

Confirmed, thank you for the easily reproducible report.

I was sure that all tests (and examples) are tested under the struct: true setting, but I see now that examples are not.

My plan is:

  • Change ${args['ARG']} to ${args['ARG']:-} in the whitelist_filter view to fix this particular violation
  • Ensure that all examples are generated and tested with strict true
  • Fix any other failing example in strict mode, which I suspect I will find

BTW - you should use lowercase when naming args (arg: option instead of arg: OPTION).

from bashly.

DannyBen avatar DannyBen commented on June 19, 2024

This is fixed now in master branch, and in the edge docker image.

I will hold off on releasing for a day or two, allowing you some time to test it if you can.

from bashly.

chovanecadam avatar chovanecadam commented on June 19, 2024

Thank you for the quick response, I will check it this evening.

from bashly.

chovanecadam avatar chovanecadam commented on June 19, 2024

I have tested the docker and the issue seems to be fixed with args as well as with flags. By the way, I use podman instead of docker, and I had to add :U flag to the volume settings to allow it read-write access to the volume. The alias then looked like this:

alias bashly='docker run --rm -it --user $(id -u):$(id -g) --volume "$PWD:/app:U" docker.io/dannyben/bashly'

(Another difference is the docker.io on the end)

from bashly.

DannyBen avatar DannyBen commented on June 19, 2024

Alright, thanks for confirming.
I will release tomorrow.

from bashly.

DannyBen avatar DannyBen commented on June 19, 2024

This is now fixed in version 1.1.2.
Thanks for reporting.

from bashly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.