Coder Social home page Coder Social logo

Comments (4)

manicmaniac avatar manicmaniac commented on June 5, 2024

It looks like an intended behavior since Danger::LocalSetup#setup forces --verbose option here.

unless verbose
cork.puts "Turning on --verbose"
dm.verbose = true
end

Not only danger local but also danger pr calls Danger::LocalSetup#setup, as a result they have the same behavior about forsing --verbose flag.

from danger.

manicmaniac avatar manicmaniac commented on June 5, 2024

@orta
How do you think about removing the behavior that forces --verbose flag in danger local and danger pr?
Since both of them are mainly for debugging purpose, I don't think no one cares about this breaking change. Those who want the current behavior are still able to add --verbose flag explicitly.

from danger.

orta avatar orta commented on June 5, 2024

Seems reasonable to me

from danger.

manicmaniac avatar manicmaniac commented on June 5, 2024

I tried danger --verbose=false pr and danger pr --verbose=false pr , but it doesn't change anything. It does seem to accept the flag though, because if it wasn't a registered one, there would be a 'unknown option' error.

I just noticed that --verbose flag may be what you want.
Surprisingly, the flag works the other way when you invoke danger pr or danger local.

#1424 should correct this behavior.

from danger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.