Coder Social home page Coder Social logo

Comments (7)

Skoti avatar Skoti commented on June 11, 2024 1

That's the point.
The #1177 PR was supposed to make it possible to run Danger from a subdirectory.
As I explained in my first post, it seems like it missed the fact that git diff always returns paths relative to the git directory instead of the current directory, hence the common part of the path is added twice.
Seems like the paths should be relativized before expansion.

from danger.

orta avatar orta commented on June 11, 2024

Would you please take a look at this?

Danger Ruby is a very mature, done OSS project, I'm afraid folks aren't going to be fixing bugs or adding features for other people, you're welcome to look at this if it is important to you though

from danger.

Cordelro avatar Cordelro commented on June 11, 2024

from danger.

Cordelro avatar Cordelro commented on June 11, 2024

#1426

from danger.

Cordelro avatar Cordelro commented on June 11, 2024

655b8463e960d576e3846607440d362c2bf403eb

from danger.

Cordelro avatar Cordelro commented on June 11, 2024

655b8463e960d576e3846607440d362c2bf403eb

from danger.

manicmaniac avatar manicmaniac commented on June 11, 2024

Honestly I don't think this is a bug.

git.renamed_files, git.modified_files and git.added_files are internally calls git diff.
I think it is natural that they return files related to top-level of the Git work tree instead of the current directory.

from danger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.