Comments (7)
That's the point.
The #1177 PR was supposed to make it possible to run Danger from a subdirectory.
As I explained in my first post, it seems like it missed the fact that git diff
always returns paths relative to the git directory instead of the current directory, hence the common part of the path is added twice.
Seems like the paths should be relativized before expansion.
from danger.
Would you please take a look at this?
Danger Ruby is a very mature, done OSS project, I'm afraid folks aren't going to be fixing bugs or adding features for other people, you're welcome to look at this if it is important to you though
from danger.
from danger.
from danger.
655b8463e960d576e3846607440d362c2bf403eb
from danger.
655b8463e960d576e3846607440d362c2bf403eb
from danger.
Honestly I don't think this is a bug.
git.renamed_files
, git.modified_files
and git.added_files
are internally calls git diff
.
I think it is natural that they return files related to top-level of the Git work tree instead of the current directory.
from danger.
Related Issues (20)
- Support custom CI check names HOT 3
- "git.modified_files" crash with xcframework HOT 3
- Danger failing suddenly
- BitBucket Server Token Authentication
- Readme and Docs inconsistent stating when Danger runs
- SwiftLint usage and exclusion rules in .swiftlint.yml HOT 1
- Publish new release to get docker image with version HOT 1
- danger executions fail, after upgrate bitbucket server to version 8.9.0 HOT 4
- Online docs out of date with source code docs
- danger Action fails on POST HOT 6
- Bitbucket Cloud access token HOT 3
- Crash in lib/danger/danger_core/message_aggregator.rb when using Ruby 3.1.4
- danger is not working with [email protected]
- without GITHUB_TOKEN HOT 2
- Compatibility with Octokit v8 HOT 2
- Faraday dependency breaks Danger in ruby 2.x containers HOT 2
- Can't Create Plugins on Windows HOT 2
- YARD document does not render Markdown HOT 1
- [bug] GitHub api request fails when PR diff is > 300 files HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from danger.