Coder Social home page Coder Social logo

danger-gitlab-gem's Issues

Incompatibility with gitlab gem v4.6.0

Hi,

There seems to compatibility issues with v4.6.0 of the gitlab gem. The relevant stacktrace is

/usr/local/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/gitlab-4.6.0/lib/gitlab/client/commits.rb:5:in `<top (required)>': Commits is not a module (TypeError)
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/gitlab-4.6.0/lib/gitlab/client.rb:6:in `block in <class:Client>'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/gitlab-4.6.0/lib/gitlab/client.rb:6:in `each'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/gitlab-4.6.0/lib/gitlab/client.rb:6:in `<class:Client>'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/gitlab-4.6.0/lib/gitlab/client.rb:5:in `<module:Gitlab>'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/gitlab-4.6.0/lib/gitlab/client.rb:3:in `<top (required)>'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/gitlab-4.6.0/lib/gitlab.rb:12:in `<top (required)>'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:127:in `require'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:127:in `rescue in require'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:40:in `require'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-5.7.0/lib/danger/request_sources/gitlab.rb:34:in `client'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-5.7.0/lib/danger/ci_source/gitlab_ci.rb:40:in `determine_merge_request_id'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-5.7.0/lib/danger/ci_source/gitlab_ci.rb:31:in `validates_as_pr?'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-5.7.0/lib/danger/danger_core/environment_manager.rb:15:in `pr?'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-5.7.0/lib/danger/danger_core/executor.rb:62:in `validate_pr!'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-5.7.0/lib/danger/danger_core/executor.rb:46:in `validate!'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-5.7.0/lib/danger/danger_core/executor.rb:21:in `run'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-5.7.0/lib/danger/commands/runner.rb:70:in `run'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/claide-1.0.2/lib/claide/command.rb:334:in `run'
	from /usr/local/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/danger-5.7.0/bin/danger:5:in `<top (required)>'
	from /usr/local/rbenv/versions/2.3.1/bin/danger:23:in `load'
	from /usr/local/rbenv/versions/2.3.1/bin/danger:23:in `<main>'

I think it would make sense specify a gitlab gem version for now while this is fixed.

bundler is missing from the dependencies

On a new container I'm using gem install danger-gitlab but danger is complaning about bundler missing when actually running. Running gem install danger-gitlab bundler instead solves it.

NoMethodError: undefined method `description' for #<Gitlab::ObjectifiedHash:0x00007f92a3261258>

Hi @orta ,

Kindly help as I am stuck at this issue. Getting NoMethodError. I have also tried individual gem versions of danger (5.5.13, 5.9.0, 5.7.1) & gitlab (4.6.1, 4.7.0). Facing different exceptions with them.

Gitlab gem 4.7.0 from irb works fine. The last working danger & gitlab integration version for me was on danger-5.3.4 & gitlab 4.2.0 on gitlab api v3 for gitlab v10.x

Recently we did an upgrade on gitlab and things are broken then on.

Env
gitlab EE v11.5
danger-gitlab - danger 5.9.0 & gitlab 4.7.0
gitlab api v4
required env variables : DANGER_GITLAB_API_TOKEN, DANGER_GITLAB_HOST, DANGER_GITLAB_API_BASE_URL are all set.

StackTrace :

NoMethodError: undefined method `description' for #<Gitlab::ObjectifiedHash:0x00007f92a3261258>
  /Users/user/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/gitlab-4.7.0/lib/gitlab/objectified_hash.rb:28:in `method_missing'
  /Users/user/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/danger-5.9.0/lib/danger/request_sources/gitlab.rb:109:in `ignored_violations_from_pr'
  /Users/user/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/danger-5.9.0/lib/danger/request_sources/gitlab.rb:105:in `fetch_details'
  /Users/user/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/danger-5.9.0/lib/danger/danger_core/environment_manager.rb:51:in `fill_environment_vars'
  /Users/user/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/danger-5.9.0/lib/danger/danger_core/dangerfile.rb:266:in `run'
  /Users/user/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/danger-5.9.0/lib/danger/danger_core/executor.rb:28:in `run'
  /Users/user/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/danger-5.9.0/lib/danger/commands/runner.rb:70:in `run'
  /Users/user/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/claide-1.0.2/lib/claide/command.rb:334:in `run'
  /Users/user/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/danger-5.9.0/bin/danger:5:in `<top (required)>'
  /Users/user/.rbenv/versions/2.4.2/bin/danger:23:in `load'
  /Users/user/.rbenv/versions/2.4.2/bin/danger:23:in `<top (required)>'
Build step 'Execute Scripts' changed build result to UNSTABLE

Initializing Dangerfile with GitLab

Hi,
I am trying to configure Danger with our GitLab setup at work. I've both danger and danger-gitlab gems installed. Whenever I do danger init, it creates Dangerfile with GitHub defaults and shows tips on creating a GitHub account for the bot etc. How do I get this configured with GitLab? I am not sure if I am missing anything. I tried danger-gitlab init which is not a valid command.

Thanks.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.