dalexhd / ft_irc

The goal of this project is to make you write your own IRC server. To do so, you will test your work with a real IRC client. Internet is ruled by solid and standards protocols that allow a strong interaction between every connected computer. It’s always good to know about it.

Hey 👋🏽, I'm DalexHD

Hi, I'm DalexHD, a Full Stack Developer 🚀 from Spain, currently, I'm a 42's school student who loves new JavaScript related technologies.

Talking about Personal Stuffs:

• 👨🏽‍💻 I’m currently working at Softpoint;
• 👨‍🎓 I’m currently studying Computer Science at 42 school;
• 🌱 I’m currently learning C;
• ⌨️ I love spaces and tabs;
• 💬 Ask me about anything, I am happy to help;
• 📫 How to reach me: [email protected];

Languages and Tools I've used:

Hosting/SaaS

Programming Languages

Databases

Frameworks

Other Tools

Personal quote

Programming is not just for coding, it also changes your way of thinking when tackling problems or challenges in your life.

---

Visitor count

ft_irc's Issues

Kick command needs a specific is_ope logic.

Remove is_ope from the command properties. In case the command is something like "kick alex" you'll need ope rights. But if it is "kick #testchannel alex" you will need to be operator of that specific channel. This means that this command instead of using generic "is_ope" property, it will use a specific logic.

SEGV:

when client "list inexistingchannel" and then "list"

Add socket listener

Currently, we are able to listen sockets. But we are missing the code at run method. This will allow us to be able to relate events with the core backend.

Server::Server(char *port, char *password) : status(1)
{
	int opt;

	// Socket specific vars/options
	if ((fd = socket(AF_INET, SOCK_STREAM, 0)) == -1)
		throw std::runtime_error("socket() failed" + std::string(strerror(errno)));
	if (setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &opt, sizeof(opt)) == -1)
		throw std::runtime_error("setsockopt() failed" + std::string(strerror(errno)));

	address.sin_family = AF_INET;
	address.sin_port = htons(std::atoi(port));
	address.sin_addr.s_addr = INADDR_ANY;

	// First we need to bind the socket to a port. If there is an error, we will throw an exception.
	if (bind(fd, (struct sockaddr *) &address, sizeof(address)) == -1)
		throw std::runtime_error("bind() failed " + std::string(strerror(errno)));
	// Now we need to listen for connections. Maxiumum of 3 connections.
	if (listen(fd, 3) == -1)
		throw std::runtime_error("listen() failed " + std::string(strerror(errno)));

	std::cout << "Server started at port " << port << " with password: " << password << std::endl
	          << "Waiting for incomming connections..." << std::endl;
}

Redundant condition: The condition 'p.size() == 0' is redundant since 'p.size() < 2' is sufficient.

Codacy detected an issue:

Message: Redundant condition: The condition 'p.size() == 0' is redundant since 'p.size() < 2' is sufficient.

Occurred on:

• Commit: 003b1eb
• File: includes/commands/PrivMsg.hpp
• LineNum: 25
• Code: if (p.size() == 0 || p.size() < 2)

Currently on:

• Commit: 871d1bb
• File: includes/commands/PrivMsg.hpp
• LineNum: 24

Client's joined channels should be accessible within client's class.

🚀 Feature

Client's joined channels should be accessible within client's class.

Motivation

In order to send a Quit notification, it must only be sent to those channels and clients that are related with the client that executes that Quit notification.
Now it sends that notification to all clients within the server, without making distinguishing if a relation exists or not.

Possible Implementation

Currently, channels contains an array of clients. In case we want clients to also contain an array of channels where he is in, we need to implement a solution in order to prevent a Circular dependency issue.

@rnavarre42 proposed me to have an array of pointers instead of an array of clients. So this problem should disappear.

Question I've related to this proposal.

1. How are we able to access client->channels[0]->name if channels aka channels[0] is not typed by a hpp header, but is typed with a pointer. Is it done by casting the pointer value, maybe?¿

2. How do we prevent infinite loop of client->channels[0]->clients[0]->channels[0]->clients[0]->channels[0]->clients[0]...?

Function parameter 'filename' should be passed by const reference.

Codacy detected an issue:

Message: Function parameter 'filename' should be passed by const reference.

Occurred on:

• Commit: c50aba1
• File: tester/includes/File.hpp
• LineNum: 24
• Code: File(std::string filename)

Currently on:

• Commit: 871d1bb
• File: tester/includes/File.hpp
• LineNum: 24