dalcib / esbuild-plugin-flow

Esbuild plugin to strip types for Flow files

Hi 👋, I'm Dalci Bagolin

An amateur developer

Connect with me:

Languages and Tools:

esbuild-plugin-flow's Issues

ENOENT no such file or directory

While attempting to bundle the sale-client package, and setting the regex to match all .js files, the plugin throws the following error:

/.../sale-client/src/plugins/FileManageService.js:3:27: ERROR: [plugin: flow] ENOENT: no such file or directory, open '/.../node_modules/sale-client/src/plugins/GetTimeService.js'

The culprit is that src/plugins/FileManageService.js in this package has an import to ./getTimeService.js so there's a casing mismatch and indeed, the file doesn't exist. However, esbuild handles this gracefully with no plugins.

This is a situation in which I think there should be a warning emitted, but no error, passing the build back to esbuild to do its thing.

Allow not checking @flow in comments

Some .flow files are not annotated but needs transformation, like react-native. So it would be nice if we can add a { force: boolean }!

[feature] jsx support

Currently plugin always return loader 'js' for further processing, but some modules contains flowtype'd jsx code in '*.js' files...

Negative Lookahead is not a valid Go Regular Expression

Hey there. Thanks for this plugin.

Using a valid regex: /(\.js(?!on)(x)?)|(\.flow(\..+)?)$/

Esbuild throws the following error:

Build Error: Error: [flow] "onLoad" filter is not a valid Go regular expression: "(\\.js(?<!\\.json)(x)?)|(\\.flow(\\..+)?)$"

While this may not be a bug in the plugin, it's definitely not something I thought I'd run into. I'll report this to esbuild as well, but at the least I think it would be good for the docs to be updated.