daikikatsuragawa / autoarm

AutoARM simplifies and automates association rule mining and related tasks.

Hi there 👋

autoarm's Issues

Implementation of unit tests for private methods

Since unit tests of private methods have not been performed, it is not possible to detect the possibility of lurking bugs.

I am also looking for ideas on how to unit test private methods.

• Name Mangling?

Use mypy and static type checking

It should be a safer project by using mypy and static type checking.

Fix the result of "Lint with flake8"

I would like to take the following measures to improve maintainability.

https://github.com/daikikatsuragawa/autoarm/runs/2877215593?check_suite_focus=true

./tests/test_recommender.py:7:22: W291 trailing whitespace
./tests/test_recommender.py:11:12: E231 missing whitespace after ','
./tests/test_recommender.py:11:16: E231 missing whitespace after ','
./tests/test_recommender.py:83:1: E302 expected 2 blank lines, found 1
./tests/test_recommender.py:105:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:111:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:116:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:122:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:127:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:133:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:138:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:144:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:149:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:152:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:164:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:170:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:175:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:181:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:186:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:192:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:197:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:203:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:208:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:211:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:220:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:226:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:231:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:237:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:242:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:248:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:253:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:259:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:264:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:267:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:279:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:285:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:290:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:296:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:301:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:307:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:312:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:318:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:323:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:329:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:334:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:340:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:351:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:357:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:362:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:368:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:373:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:379:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:384:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:390:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:395:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:398:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:410:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:416:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:421:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:427:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:432:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:438:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:443:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:449:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:454:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:457:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:466:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:472:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:477:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:483:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:488:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:494:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:499:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:505:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:510:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:513:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:525:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:531:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:536:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:542:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:547:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:553:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:558:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:564:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:569:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:575:5: E741 ambiguous variable name 'l'
./tests/test_recommender.py:580:5: E266 too many leading '#' for block comment
./tests/test_recommender.py:586:5: E741 ambiguous variable name 'l'
./tests/test_frequent_itemsets.py:7:22: W291 trailing whitespace
./tests/test_frequent_itemsets.py:11:12: E231 missing whitespace after ','
./tests/test_frequent_itemsets.py:11:16: E231 missing whitespace after ','
./tests/test_association_rules.py:7:22: W291 trailing whitespace
./tests/test_association_rules.py:11:12: E231 missing whitespace after ','
./tests/test_association_rules.py:11:16: E231 missing whitespace after ','
./tests/test_dataset.py:7:22: W291 trailing whitespace
./tests/test_dataset.py:11:12: E231 missing whitespace after ','
./tests/test_dataset.py:11:16: E231 missing whitespace after ','
./autoarm/__init__.py:3:1: F401 'autoarm.association_rules.AssociationRules' imported but unused
./autoarm/__init__.py:4:1: F401 'autoarm.dataset.Dataset' imported but unused
./autoarm/__init__.py:5:1: F401 'autoarm.frequent_itemsets.FrequentItemsets' imported but unused
./autoarm/__init__.py:6:1: F401 'autoarm.recommender.Recommender' imported but unused
8     E231 missing whitespace after ','
48    E266 too many leading '#' for block comment
1     E302 expected 2 blank lines, found 1
36    E741 ambiguous variable name 'l'
4     F401 'autoarm.association_rules.AssociationRules' imported but unused
4     W291 trailing whitespace
101

Use poetry

I want to manage this project using poetry.