dagthomas / comfyui_dagthomas

ComfyUI SDXL Auto Prompter

Hi there 👋

comfyui_dagthomas's Issues

issue when picking artform/phototype

hello. sorry if its not an issue. its also my first time writing one on github.
i am not even sure how to describe it.

so when i pick an artform which isnt photography the photo_type wont get added to the prompt.
but when i pick photography and an phototype (for example front view) it looks like that its ignoring the phototype.

what i am trying to do is testing all photographer with consistent settings but they seem inconsistent when picking the settings i picked.

is it an issue with myself or the code?

still nice work! a lot of fun playing with it.

【BUG】Small problem with "lighting" and "default tags"

a great job.

But there are two small problems:

1. it doesn't handle the "disabled lighting" situation, which leads to frequent wheelchair-bound characters:
   '''
   lighting = kwargs.get('lighting', "").lower()
   if lighting == "random":
   selected_lighting = ", ".join(random.sample(self.LIGHTING, random.randint(2, 5)))
   components.append(selected_lighting)
   else:
   components.append(lighting)
   '''
2. the "default tags" are invalid:
   '''
   params = [
   ('subject', 'default_tags', self.DEFAULT_TAGS),
   ('roles', self.ROLES),
   '''

Required input is missing

• PromptGenerator 1:
  • Required input is missing: seed
    Output will be ignored

What "seed" is being referred to if there is no such field in the node and only one "string" output?
Or do I not understand how to use this node?

【Bug】A little nitpick about "lighting" and "default tags"

a great job.

But there are two small issues:

1. it doesn't handle the "disabled lighting" situation, which leads to frequent wheelchair-bound characters:
   '''
   lighting = kwargs.get('lighting', "").lower()
   if lighting == "random":
   selected_lighting = ", ".join(random.sample(self.LIGHTING, random.randint(2, 5)))
   components.append(selected_lighting)
   else:
   components.append(lighting)
   '''
2. the "default tags" is invalid:
   '''
   params = [
   ('subject', 'default_tags', self.DEFAULT_TAGS),
   ('roles', self.ROLES),
   '''