dabolus / cookie-consent Goto Github PK

Hi Dabolus,

are you planning a lit-element or at least Polymer 3 version of this element? If not, do you mind a PR?

Cheers!

As a DEVELOPER I want to have a property to enable/disable the IP location functionality.

Hi! Nice component!

I'm using the v1 if this component and I was trying to not check the user country, I just want to always show the cookie banner not matter where they are (At this moment there's no way to disable this in the component) so what I did was to set the geoIpUrl to nothing (geo-ip-url="") and after this the console output this:

cookie-consent.html:274 Uncaught TypeError: Cannot use 'in' operator to search for 'country_code' in null
    at HTMLElement._checkCountryCode (cookie-consent.html:274)
    at HTMLElement.handler (polymer.html:507)
    at HTMLElement.fire (polymer.html:1284)
    at HTMLElement._handleResponse (iron-ajax.html:512)
    at <anonymous>

I checked the component's code and there's a line where you check if there's a property with the name set in geoIpParam inside the response of the iron-request.
https://github.com/Dabolus/cookie-consent/blob/master/cookie-consent.html#L280

Note: This is happenning on the v2 too.

The problem is that before this if you check if response is an object:
https://github.com/Dabolus/cookie-consent/blob/2.0/cookie-consent.html#L277

And in my use case response is null and typeof null === 'object' is true.

I've created 2 PR to fix this in both versions (v1 and v2)

#1
#2

Thanks for your time and regards.

Hi Dabolus,

I am Binh, the author of the series Web Components Wednesday, where I will review some components every Wednesday.

The blog Cookie web components for displaying consent and managing cookie data featured your component, cookie-consent. I believe it is extremely useful during this GDPR era.

It would be great if you, the original author can have a word in the comment section.

Cheers,
Binh