dabapps / crab Goto Github PK

Currently the environment variables that can be set to adjust how crab functions are spread all over the place. It'd be nice to have a small list of them with summaries, that links to the relevant more detailed information.

1. Move to top of readme
2. Document commands needed to install from GitHub (virtual env etc)
3. Note about running chmod +x ./path/crab to make executable

...or fix the binary?

It'd be nice if this were output in the terminal, as currently it only states the default http://127.0.0.1:8080/, this way users can click-through to the app they're running.

if (command[0] == "web" ...

This doesn't work because by the time we get to this point, command has already been replaced with the contents of the procfile.

Need to save the original command in a separate variable (or something)

Add support for multi-line env variables in the .env file

eg

RSA_KEY_DATA="-----BEGIN RSA PRIVATE KEY-----
keydataline1
keydataline2
-----END RSA PRIVATE KEY-----"

There should be some.

At the moment I'm getting something like the following output:

$ crab things

Traceback (most recent call last):
  File "/usr/local/bin/crab", line 11, in <module>
    load_entry_point('crabtools==0.1.2', 'console_scripts', 'crab')()
  File "/usr/local/Cellar/crab/0.1.2/libexec/lib/python3.7/site-packages/crab/cli.py", line 77, in main
    os.execvpe(command[0], command, env)
  File "/usr/local/Cellar/crab/0.1.2/libexec/bin/../lib/python3.7/os.py", line 583, in execvpe
    _execvpe(file, args, env)
  File "/usr/local/Cellar/crab/0.1.2/libexec/bin/../lib/python3.7/os.py", line 616, in _execvpe
    raise last_exc
  File "/usr/local/Cellar/crab/0.1.2/libexec/bin/../lib/python3.7/os.py", line 607, in _execvpe
    exec_func(fullname, *argrest)
FileNotFoundError: [Errno 2] No such file or directory: b'/Users/username/.rvm/bin/things'

It would be nicer if we output something like:

Could not find "things" in your procfile or $PATH

$ DATABASE_URL="not a database url" crab env | grep DATABASE               
DATABASE_URL=postgres://localhost/db

crab should only set environment variables when they're not defined in the project itself. I think?

After installing crab, and trying to run crab, it outputs some nonsense error which made me think that it was not correctly installed. This wasted a bunch of my time.

There's an issue in PyInstaller which may be related: pyinstaller/pyinstaller#208

When using the binary version of Crab terminating some programs results in the iTerm terminal window freezing on MacOS. It does not appear to affect Linux.

Steps to reproduce

1. Open iTerm on MacOS
2. Execute the command: crab python
3. On your keyboard; hold CTRL and strike Z.

Your terminal window should now be completely frozen.

It'd be nice to have some way of finding out what version of Crab you're running. This could be a numerical version or just a git sha, but either way we need to bake it in to the binary we build with pyinstaller. Maybe need to create a "release" script which does it somehow?