da-wen / phpredisbundle Goto Github PK

The tests require Tests/autoload.php.dist, it would be great if you could either add the file or require vendor/autoload.php instead.

Many methods can be called with variadic parameters. The bundle often handles up to 3 instead. This obviously is wrong behavior.

The AbstractKernelAwareTest explicitly requires a Kernel outside the project directory. Including a Kernel in the project seems like the better option to me.

New commands have been added to both redis and the php extension since this bundle was created. Those are still missing from the bundle, of course.

The test for EXPIREAT in RedisClientKeysIntegrationTest::testExpireAt assumes that time on the server nearly equals that on the local machine. The test may fail based on that assumption not holding true. Maybe using TIME to ask for the servers time would be the better approach here?