d4goxn / gh-api-test Goto Github PK

Jira: KSR-732

When the hamburger menu is open and the user scrolls the content of the ADP page scroll. Instead that content must be fixed and not scrollable.

Jira: KSR-718

Jira: KSR-698

Add width for a single column, so that articles stack.

Jira: KSR-695

Jira: KSR-697

1. Markup should not be shown to the user.

2. It would let us build a text editor that is identical to the BF text editor, except that the author would see their text as it will appear to a reader, instead of seeing markup.

3. There will be no way for them to add any markup other than and

   tags, and the details of those will be governed by our business logic. -The formatting menu and popup, and related UX, will still match the BF text editor, except where our specs specify otherwise.

4. always send html to contentChanged callback, we will keep doing that. We store the text as html.

5. The user will add tags using the side menu and popup, and they will add

   tags by adding newlines. None of that changes.

This might mean that the HTML5 content-editable approach is the best solution.

Jira: KSR-703

https://bitbucket.org/menapost/block-editor-components/issues/3/align-left-side-of-inputs-and-labels-in

Jira: KSR-725

We decided not to bold Arabic text a while ago, but the spec was not updated in Jira.

Jira: KSR-702

When expanding an item in the hamburger menu the entire row is highlighted white. When the user scrolls that white bar overlaps with the white hamburger menu icon. The horizontal area where the hamburger menu icon is should not overlap with the rest of the menu

Jira: KSR-721

https://screencloud.net/v/4G08

Jira: KSR-738

IMPORTANT: before starting this task make sure that you have finished:

• KSR-693. KSR-692

We need to change href links (RED ARROWS: http://scr.hu/29ir/6b230) to the react-router links (the same way (or similar):

!http://screenshu.com/static/uploads/temporary/21/5w/22/cvpyxq.jpg!

Jira: KSR-689

Jira: KSR-737

Jira: KSR-690

Jira: KSR-731

Jira: KSR-691

On scroll the social sharing buttons (Facebook and Twitter) slide down with animation. They should just appear without any animation

Currently the Height is animated. It's better to remove the menu / social button's in DOM.

[~Andrew] -> Remember: REUSE header state from the component.

http://scr.hu/29ir/5jmdr

Jira: KSR-711

When hovering on "All" a menu slides down. When the user scrolls with the menu open it should slide back up and close.

this transition: http://scr.hu/29ir/2j0d6 & http://scr.hu/29ir/kl3cv

Jira: KSR-710

Move click event to list item instead of a tag.

Jira: KSR-730

Jira: KSR-709

Jira: KSR-701

Jira: KSR-727

Repo: https://bitbucket.org/menapost/global-top-component-styles

Based on today's catch-up with [~dan] & [~william] all global styles needs to go to a new global repository.

We need to move all the styles that are based in /demo/ folder into that new repo.

THE GOAL: we need to have single source of global styles for:

• main top kasra app
• all the demo versions of component across the whole Kasra's related components

Jira: KSR-704

Reset hamburger menu state / close submenus when exiting Hamburger menu (desktop and mobile). Currently if a sub menu is expanded and the user exits the hamburger menu, on reopening the menu item is expanded instead of being at default state

*PLEASE NOTE: *This task require using reflux (we believe).

1. DEFAULT STATE: http://scr.hu/29ir/vzdrb

2. USE REFLUX: http://scr.hu/29ir/gki0l - to reset state

3. USER CLICKS close: http://scr.hu/29ir/jnk9n

4. WE GET BACK THE DEFAULT AGAIN: http://scr.hu/29ir/vzdrb (now it doesn't reset, so we need to make it works)

Jira: KSR-714

https://bitbucket.org/menapost/block-editor-components/issues/1/do-not-show-border-or-controls-on-preview

Jira: KSR-723

The social sharing buttons in the nav bar that appear on scroll should only appear when the user is on an Article Detail Page (ADP). All other pages (e.g. homepage, tertiary pages, etc) should not show these buttons.

We are talking about those buttons: http://scr.hu/29ir/5jmdr - use child-prop

Jira: KSR-712

https://bitbucket.org/menapost/block-editor-components/issues/5/do-not-allow-the-user-to-change-the-width

Jira: KSR-726

PLEASE WORK ON THIS BRANCH: https://bitbucket.org/menapost/altjs-kasra-app/commits/branch/feature-KSR-693. add-header

Before starting this task, we need to have completed task KSR-692.

By completed I mean that on this route (http://scr.hu/29ir/qcf1m) we see the landing-component rendered properly.

We see properly, the landing component: three squares shall be styled properly the same way as on kasra website (http://scr.hu/29ir/r3hx4) - DATA IS STILL MOCKED AT THIS POINT (there are no real images & titles, yet).

When we have running well the landing-page component in the altjs routes (it renders correctly). Then we need to start modifing the landing-component (https://bitbucket.org/menapost/landing-page) in order to add this header component (https://bitbucket.org/menapost/header-components) to the landing-component (in another words: we need add header-component to the landing-page component).

IMPORTANT: you need add the header component into the landing-component.

STEPS:

1. clone this repo: https://bitbucket.org/menapost/landing-page

2. clone this repo and run the demo: https://bitbucket.org/menapost/header-components

3. MAKE SURE HOW in the header-component /demo/dist/ are correctly rendered the styles

4. find the way to add this header-component (with correct styles) to landing-component (check Style Management's email if you are not sure how)

THE FINAL OUTPUT (of running the altjs kasra app - https://bitbucket.org/menapost/altjs-kasra-app) SHALL LOOK SIMILAR TO THIS:

!http://screenshu.com/static/uploads/temporary/2d/n5/5v/xlo93x.jpg!

IF ANY QUESTION - PLEASE REACH ME ON MY MOBILE: 0048 515 668 551

Jira: KSR-693

Drop empty block on ok/cancel.

Drop block on cancel.

Jira: KSR-734

Jira: KSR-729

Jira: KSR-707

We need to QA on IE & safari to check how this part of the code is behaving: http://scr.hu/29ir/c9idc

Mostly it's related to this part:

var doc = element.ownerDocument || element.document;

&
} else if ( ( sel = doc.selection ) && sel.type !== "Control" ) {

Jira: KSR-722

We need to make back the landing-page working. Currently the landing-page's styles doesn't work: http://scr.hu/29ir/yjc5z

Jira: KSR-735

see https://bitbucket.org/menapost/navigation/issue/1/styles-cannot-be-compiled-unless-compiled

Jira: KSR-694

https://bitbucket.org/menapost/block-editor/issues/2/slug-and-url-position-flips-when-entering

Jira: KSR-728

Hamburger menu should not scroll past the last item

Jira: KSR-719

UX designs: https://files.slack.com/files-pri/T048MRSB0. F07JDNDNH/ux_editorcms_errormessages.pdf

Jira: KSR-733

Jira: KSR-699

Acceptance

When the text cursor is in a link, the link tool should be shown

The URL should be editable in the link tool

When the link tool loses focus, it should update the link URL in the text

Jira: KSR-706

1. clone repo: https://bitbucket.org/menapost/altjs-kasra-app ----> http://scr.hu/29ir/yrgpb

2. clone repo: https://bitbucket.org/menapost/landing-page

3. test landing page (run /demo/) - see what styles are in demo

4. make this landing-component (2. point) running on that route: http://scr.hu/29ir/uskaf

The goal is to make this route run the same way as on www.kasra.co/quiz etc.

PLEASE NOTE: see what Dan has answered in that email: http://scr.hu/29ir/tks2e ...

Jira: KSR-692

The menu items in the hamburger menu fade in and out when opening or closing the hamburger menu. The items of the menu should not be animate when the menu is opened or closed.

Note animating items when expanding and collapsing sub categories is ok

Jira: KSR-717

There is a white X ixon behind the hamburger menu icon. This should not be there

HERE IS THE SCREENSHOT from the (nav-overlay component): http://scr.hu/29ir/cmmw4

Jira: KSR-715

Jira: KSR-696

MAKE THE APP AWARE OF:

1. this goes everywhere: http://scr.hu/29ir/qzksc

2. this appears only on the article page: http://scr.hu/29ir/98rp5

ONLY on ARTICLE PAGE THIS SHOWS UP: http://scr.hu/29ir/2j0d6

And on other this one: http://scr.hu/29ir/j373o

Hamburger menu (this is it: http://scr.hu/29ir/5lyf0) should appear in the following scenarios only:

• mobile all pages
• desktop ADP pages only

Jira: KSR-713

Jira: KSR-708

Jira: KSR-700

Jira: KSR-688

[~Andrew] please confirm with [~william] that's 100% ready for merging into top level kasra's app.

https://bitbucket.org/menapost/header-components/branch/child-prop

Jira: KSR-736

MORE DETAILS: http://scr.hu/29ir/0ua63. what is the issue. FIXED HEIGHT issue (we need to calculate dynamically).

If you expand all items in the hamburger menu you will see large gaps between items as well as a large space below the last item

Jira: KSR-716

https://bitbucket.org/menapost/block-editor-components/issues/2/move-character-counter-below-text-input

Jira: KSR-724

Currently multiple hamburger menus can be expanded at the same time

Jira: KSR-720