d3kion / monuments-app Goto Github PK
View Code? Open in Web Editor NEWGIS app with Django backend and Backbone.js/Marionette.js/OpenLayers frontend
GIS app with Django backend and Backbone.js/Marionette.js/OpenLayers frontend
Instead of
Application.extend({
...
})
try to use es6 class syntax in project. Something like this
class App extends Application {
...
}
It is better not to use direct comparison with undefined, as in this line
https://github.com/D3kion/django-tutorial/blob/5a582bc154a861e42101a0c61990fb3e97d6447a/frontend/src/app/login/view.js#L31
monuments-app/frontend/src/app/views/main/map.js
Lines 285 to 292 in c5c2729
monuments-app/backend/api/views.py
Line 93 in edd43bb
monuments-app/frontend/src/app/views/main/menu/feature.js
Lines 12 to 18 in c5c2729
Why did you add this file here? (frontend/src/styles/bootstrap.min.css)
You need to import it from node_modules.
When hovering over an layer object, it would be convenient to add 'cursor: pointer'. So that the user understands that you can click on the layer object to view the information.
pipenv (github) - https://github.com/pypa/pipenv
monuments-app/frontend/src/app/utils.js
Line 34 in c5c2729
While image is loading you can use preloader.
Now you have 0% of test coverage. Check it.
Something like this
$ coverage run --branch --source=app1,app2 ./manage.py test
$ coverage report
$ coverage html -d coverage-report
It is recommended to configure the library used on the client for HTTP requests so that the token is included in the request headers automatically.
Small typo. The word should be "description" not "desription."
It is necessary to add an attribute to the buttons 'Edit' and 'Delete'. You may need to add to the other buttons too, which contain only the icon.
Try to use destructuring where is possible
In this case usage of 'HTTP_404_NOT_FOUND' status is not correct.
if not user:
return Response({'detail': 'Invalid credentials'},
status=HTTP_404_NOT_FOUND)
Pay attention to https://www.django-rest-framework.org/api-guide/status-codes/
https://github.com/D3kion/django-tutorial/blob/c833c7a13c3cfaf5d811a36903876e7748881ab7/backend/api/views.py#L47
Try to use one code style in project.
Here I find out lines without spaces.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.